Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1618#discussion_r74315902
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -479,6 +479,17 @@ public SnapshotResponse
createSnapshotResponse(Snapshot snapshot) {
if (zone != null) {
snapshotResponse.setZoneId(zone.getUuid());
}
+
+ if (volume.getVolumeType().equals(Volume.Type.ROOT)) {
--- End diff --
Enumerated values are guaranteed to be singletons. Therefore, the ``==``
operator deterministically performs both reference and value equality checks.
It is also preferred because it avoid an NPE in the event that
``volume.getVolumeType()`` returns null.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
