Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1618#discussion_r74316221 --- Diff: server/src/com/cloud/api/ApiResponseHelper.java --- @@ -479,6 +479,17 @@ public SnapshotResponse createSnapshotResponse(Snapshot snapshot) { if (zone != null) { snapshotResponse.setZoneId(zone.getUuid()); } + + if (volume.getVolumeType().equals(Volume.Type.ROOT)) { + VMInstanceVO instance = ApiDBUtils.findVMInstanceById(volume.getInstanceId()); + if (instance != null) { + GuestOS guestOs = ApiDBUtils.findGuestOSById(instance.getGuestOSId()); --- End diff -- It feels like lines 484 & 486 could be combined into a single join exposed by a method on ``VolumeDao``. Do you agree?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---