GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1648
test/integration: fix tearDown order in list_acl_ tests
test/integration: fix tearDown order in list_acl_ tests
In several of the list_acl_tests, the tests run for simulator only where
in the (class) setup domains and accounts are created for the test.
When the
tests end the (class) teardown methods would delete and remove these
resources.
Due to dependence of one of the resources on the other, domain2 on
domain1,
domain2 needs to be removed/cleaned up before domain1. Due to this
issue,
several Travis test runs have failed in the past such as:
https://travis-ci.org/apache/cloudstack/jobs/152610967
https://travis-ci.org/apache/cloudstack/jobs/152610968
Changing the order of cleanup fixes the tests.
/cc @jburwell @karuturi
The fix is specific to tests that run 'only' on simulator with Travis. A
passing Travis run should be enough to validate the changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.9-fixmarvintest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1648.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1648
----
commit a9acadda95c05a6af1f7c1ebf1dd2591479fd8ba
Author: Rohit Yadav <[email protected]>
Date: 2016-08-19T11:42:09Z
test/integration: fix tearDown order in list_acl_ tests
In several of the list_acl_tests, the tests run for simulator only where
in the (class) setup domains and accounts are created for the test. When the
tests end the (class) teardown methods would delete and remove these
resources.
Due to dependence of one of the resources on the other, domain2 on domain1,
domain2 needs to be removed/cleaned up before domain1. Due to this issue,
several Travis test runs have failed in the past such as:
https://travis-ci.org/apache/cloudstack/jobs/152610967
https://travis-ci.org/apache/cloudstack/jobs/152610968
Changing the order of cleanup fixes the tests.
Signed-off-by: Rohit Yadav <[email protected]>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
