[GitHub] cloudstack issue #871: CLOUDSTACK-8893: Fixing script as per the latest func...

[serg38]

Github user serg38 commented on the issue:

    https://github.com/apache/cloudstack/pull/871
  
    @jburwell @rhtyd @karuturi @nvazquez I assume the current code doesn’t 
allow volume snapshots on the top of vmsnapshots on purpose. In that case is it 
best to revert PR871 or create a new PR to address the Marvin script?
    
    From: Nicolas Vazquez <notificati...@github.com>
    Reply-To: apache/cloudstack <re...@reply.github.com>
    Date: Wednesday, September 21, 2016 at 11:15 AM
    To: apache/cloudstack <cloudst...@noreply.github.com>
    Cc: Sergey Levitskiy <sergey.levits...@autodesk.com>, Mention 
<ment...@noreply.github.com>
    Subject: Re: [apache/cloudstack] CLOUDSTACK-8893: Fixing script as per the 
latest functionality (#871)
    
    
    Hi @sanju1010<https://github.com/sanju1010>,
    
    @serg38<https://github.com/serg38> and I are working on this PR 
#1677<https://github.com/apache/cloudstack/pull/1677> which solves vm snapshot 
creation issue. After running test_vm_snapshots.py we're getting exception on 
test_01_test_vm_volume_snapshot as it was expected before your changes in this 
PR.
    
    We're getting: 'CloudstackAPIException: Execute cmd: createsnapshot failed, 
due to: errorCode: 431, errorText:Volume snapshot is not allowed, please detach 
it from VM with VM Snapshots\n']
    
    This is consistent with VolumeApiServiceImpl.allocSnapshot method, in which 
it is:
    
            if (volume.getInstanceId() != null) {
    
                // Check that Vm to which this volume is attached does not have 
VM Snapshots
    
                if (_vmSnapshotDao.findByVm(volume.getInstanceId()).size() > 0) 
{
    
                    throw new InvalidParameterValueException("Volume snapshot 
is not allowed, please detach it from VM with VM Snapshots");
    
                }
    
            }
    
    Do you want us to adapt test_vm_snapshots.py in mentioned PR to support 
this or would you like to address it yourself?
    
    Thanks
    
    —
    You are receiving this because you were mentioned.
    Reply to this email directly, view it on 
GitHub<https://github.com/apache/cloudstack/pull/871#issuecomment-248696674>, 
or mute the 
thread<https://github.com/notifications/unsubscribe-auth/APbWPq2NlxyRQADHpD6ucL5jzTkZ_Zy1ks5qsXQpgaJpZM4GBeLo>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---