Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1678#discussion_r80063935
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -279,12 +280,12 @@
@Override
public ExecutionResult executeInVR(final String routerIp, final String
script, final String args) {
- return executeInVR(routerIp, script, args, _timeout / 1000);
+ return executeInVR(routerIp, script, args, _timeout);
}
@Override
- public ExecutionResult executeInVR(final String routerIp, final String
script, final String args, final int timeout) {
- final Script command = new Script(_routerProxyPath, timeout *
1000, s_logger);
+ public ExecutionResult executeInVR(final String routerIp, final String
script, final String args, final Duration milli) {
+ final Script command = new Script(_routerProxyPath,
milli.getMillis(), s_logger);
--- End diff --
Please consider adding an overridden version of the `Script(String, int,
Logger)` constructor that accepts a `Duration` instance to encapsulate this
conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
