Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1678#discussion_r80065456
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
    @@ -1265,11 +1266,11 @@ private ExecutionResult 
prepareNetworkElementCommand(IpAssocCommand cmd) {
     
         @Override
         public ExecutionResult executeInVR(String routerIP, String script, 
String args) {
    -        return executeInVR(routerIP, script, args, 120);
    +        return executeInVR(routerIP, script, args, 
Duration.standardSeconds(120L));
    --- End diff --
    
    Please consider extracting ``Duration.standardSeconds(120L)`` to a constant 
to clarify intent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to