Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1813#discussion_r102649977
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
    @@ -703,6 +703,16 @@ private Answer execute(ResizeVolumeCommand cmd) {
                 }
     
                 VirtualDisk disk = vdisk.first();
    +            if(vdisk.second()!=null && 
!vdisk.second().toLowerCase().contains("scsi"))
    --- End diff --
    
    @priyankparihar _vdisk.second()_ here holds the disk bus name, that would 
ide0:0,... (or) scsi0:0,...
    I think startsWith("scsi") check would be more precise.
    
    Move "_VirtualDisk disk = vdisk.first();_" stmt below this if check. For 
all non-scsi disks, the _disk_ var is unnecessarily stacked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to