Github user serg38 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1813#discussion_r105932339
  
    --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py ---
    @@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self):
             # 2. root disk has new size per listVolumes
             # 3. Rejects non-supported hypervisor types
             """
    -        if(self.hypervisor.lower() == 'kvm'):
    +        full_clone_config = Configurations.list(self.apiclient,
    +                            name="vmware.create.full.clone")[0].value
    +        if full_clone_config == 'false' and self.hypervisor.lower() == 
'vmware':
    +            self.skipTest("root disk resize is not supported "+
    +                "when vmware.create.full.clone is %s" % full_clone_config)
    +
    --- End diff --
    
    @priyankparihar @cloudsadhu test_rootvolume_resize.py test looks good. Can 
we add exactly the same logic of adding full clone config for smoke test 
test_deploy_vm_root_resize.py so that it is not skipped if a global setting is 
to use link clones?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to