Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1941#discussion_r102730127
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1415,6 +1417,10 @@ public VM createWorkingVM(final Connection conn,
final String vmName, final Stri
vbdr.userdevice = "autodetect";
vbdr.mode = Types.VbdMode.RW;
vbdr.type = Types.VbdType.DISK;
+ Long deviceId = volumeTO.getDeviceId();
+ if (deviceId != null && (!isDeviceUsed(conn, vm, deviceId) ||
deviceId > 3)) {
--- End diff --
There is this one also https://github.com/apache/cloudstack/pull/1829.
However, after sorting out the tests failures and with the code approved I
don't think that this would be a reason to not take the PR forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
