Github user syed commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1963#discussion_r102798055
  
    --- Diff: 
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ---
    @@ -711,6 +711,7 @@ private void 
handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
             }
             catch (Exception ex) {
                 errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy 
operation failed in 
'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
    +            copyCmdAnswer = new CopyCmdAnswer(errMsg);
    --- End diff --
    
    That would be great @mike-tutkowski. That makes sure that the snapshot goes 
back to a good state if the storage driver operation fails. I will close this 
request then.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to