Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105881247
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -1049,7 +1044,13 @@ public boolean executeUserRequest(final long hostId,
final Event event) throws A
}
return true;
} else if (event == Event.ShutdownRequested) {
- return reconnect(hostId);
+ //should throw a exception here as well.instead of eating this
up.
+ try {
+ reconnect(hostId);
+ } catch (CloudRuntimeException e) {
--- End diff --
@sureshanaparti
I agree with you, I have also added a comment in the code indicating the
same. We can work on it in a different pr. This is just a small improvement to
the existing code. Fixing this will need lot of rework and cause code churn. So
the intention was to do this later in a separate PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
