Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r105881440
--- Diff:
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
---
@@ -512,7 +512,11 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
});
HostVO host = _hostDao.findById(lbDeviceVo.getHostId());
- _agentMgr.reconnect(host.getId());
+ try {
+ _agentMgr.reconnect(host.getId());
+ } catch (Exception e ) {
--- End diff --
Using a more specific catch makes sense, I will take this up in a separate
PR. This was supposed to be a small improvement to the existing code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
