Agree. Will create rc6 soon. ~Rajani
Sent from phone. On 23 Jun 2017 3:17 p.m., "Wido den Hollander" <w...@widodh.nl> wrote: > > > Op 22 juni 2017 om 21:38 schreef Kris Sterckx < > kris.ster...@nuagenetworks.net>: > > > > > > Sorry , i meant PR/2084 <https://github.com/apache/cloudstack/pull/2084 > > > > > > Ok, so revert and RC6 then? > > Wido > > > On 22 June 2017 at 21:25, Kris Sterckx <kris.ster...@nuagenetworks.net> > > wrote: > > > > > Hi all > > > > > > > > > Thanks to Daan for driving the work at PR/2155 > > > <https://github.com/apache/cloudstack/pull/2155> , but i believe it > needs > > > more soak time. > > > > > > We found today this PR is breaking VR-provided Guest DNS for SDN > providers > > > also. > > > > > > As Daan also suggested, i would recommend taking it out 4.10 and give > it > > > some more cycles in 4.11. > > > > > > We will support qualifying it. > > > > > > thanks, > > > > > > Kris > > > > > > - Nuage Networks > > > > > > On 21 June 2017 at 16:45, Kris Sterckx <kris.ster...@nuagenetworks.net > > > > > wrote: > > > > > >> Hi Wido, Daan, all > > >> > > >> > > >> We have just pushed a workaround > > >> > > >> https://github.com/apache/cloudstack/pull/2155 > > >> > > >> This works for us. > > >> > > >> The CsPassword class seems like not needed at all ? The important > part > > >> for us is that iptables_change = True is set also in case of > password > > >> handling. That was missing. > > >> > > >> Daan, we left a TODO for you to look into deeper though. We worked at > > >> getting the databag handling fixed inside the class but as we don't > have > > >> full background, we kept hitting issues. Until we then saw that > commenting > > >> out the lines which we did actually works as well. > > >> > > >> I suggest the /2155 is reviewed by the involved stakeholders and > based on > > >> that we decide ? > > >> > > >> > > >> thanks and toi-toi :-) > > >> > > >> > > >> Kris > > >> > > >> > > >> > > >> > > > > > > >
