+1 on removing unused code. 2017-09-26 11:16 GMT-03:00 Marc-Aurèle Brothier <ma...@exoscale.ch>:
> +1 to sort them too > > On Tue, Sep 26, 2017 at 4:13 PM, Daan Hoogland < > daan.hoogl...@shapeblue.com> > wrote: > > > +1 Sigert, be my guest. We will run integration tests on your changes > > anyway, so low risk ;) > > > > On 2017/09/26 15:55, "Rafael Weingärtner" <raf...@autonomiccs.com.br> > > wrote: > > > > IMO, if something is not used or if something does not work, it has > to > > be removed or fixed. > > > > I am +1 for the removal of unused constants. Did you check if the > value > > of these unused constants were being used somewhere? I mean, using > the > > value without referencing the constant. > > > > > > On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote: > > > Hi all, > > > > > > Am I allowed to remove all unused constants in ApiConstants.java? > > > > > > Kind regards, > > > > > > *Sigert Goeminne* > > > Software Development Engineer > > > > > > > -- > > Rafael Weingärtner > > > > > > > > > > daan.hoogl...@shapeblue.com > > www.shapeblue.com > > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > > @shapeblue > > > > > > > > >
