+1 of course, please let us know when you submit the PR and we’ll run some tests on it.
Thanks, Boris Stoyanov boris.stoya...@shapeblue.com www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue > On Sep 26, 2017, at 6:48 PM, Nitin Kumar Maharana > <nitinkumar.mahar...@accelerite.com> wrote: > > +1 for removal of unused ones but prior to remove, Can you please check once > what Rafael suggested. "using the value without referencing the constant”. > > > Thanks, > Nitin > On 26-Sep-2017, at 7:25 PM, Rafael Weingärtner > <raf...@autonomiccs.com.br<mailto:raf...@autonomiccs.com.br>> wrote: > > IMO, if something is not used or if something does not work, it has to be > removed or fixed. > > I am +1 for the removal of unused constants. Did you check if the value of > these unused constants were being used somewhere? I mean, using the value > without referencing the constant. > > > On 9/26/2017 9:55 AM, Sigert GOEMINNE wrote: > Hi all, > > Am I allowed to remove all unused constants in ApiConstants.java? > > Kind regards, > > *Sigert Goeminne* > Software Development Engineer > > > -- > Rafael Weingärtner > > > DISCLAIMER > ========== > This e-mail may contain privileged and confidential information which is the > property of Accelerite, a Persistent Systems business. It is intended only > for the use of the individual or entity to which it is addressed. If you are > not the intended recipient, you are not authorized to read, retain, copy, > print, distribute or use this message. If you have received this > communication in error, please notify the sender and delete all copies of > this message. Accelerite, a Persistent Systems business does not accept any > liability for virus infected mails.
