Great work Daan! paul.an...@shapeblue.com www.shapeblue.com 3 London Bridge Street, 3rd floor, News Building, London SE1 9SGUK @shapeblue
-----Original Message----- From: Daan Hoogland <daan.hoogl...@gmail.com> Sent: 14 February 2020 18:45 To: dev@cloudstack.apache.org Subject: Re: [DISCUSS]/[PROPOSAL] draft PRs Thanks all for the swift responses. Let's just start doing this. No need for a vote until someone starts a discussion on the subject. Agree? On Fri, 14 Feb 2020, 17:04 Rohit Yadav, <rohit.ya...@shapeblue.com> wrote: > +1 (better than changing the PR subject, putting wip-labels or [WIP]) > > Regards, > > Rohit Yadav > > Software Architect, ShapeBlue > https://www.shapeblue.com > > rohit.ya...@shapeblue.com > www.shapeblue.com > @shapeblue > > > > ------------------------------ > *From:* Daan Hoogland <daan.hoogl...@gmail.com> > *Sent:* Friday, February 14, 2020 17:33 > *To:* dev <dev@cloudstack.apache.org> > *Subject:* [DISCUSS]/[PROPOSAL] draft PRs > > devs, I thought I had already sent a mail about this but i cannot find it. > I'm sure i had mentioned it somewhere (probably on github). > this is a follow up on [1] and hopefully you'll agree, a slight > improvement. > > here it comes: > > At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag > in the title. This title stands the chance of being merged once we > agree the PR is ready for merge. It also clutters the title. > > Github has introduced a nice feature a while ago; draft PR. When > creating a PR you can opt not to open it for merge but as draft. > Choose a button left of the "Create pull request" button, marked > "Create draft PR". It will be a full PR with all CI and discussion > possibilities open. The only difference is the merge button being > disabled. One will than have to make/mark it "ready for merge" before it > *can* be merged. > > [1] > > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037 > f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E > please shoot any comments you may have back at me, thanks > > -- > Daan >
