+1 from me :) On Fri, Feb 14, 2020, 09:48 Sven Vogel <s.vo...@ewerk.com> wrote:
> +1 (The title are better readable) > > > __ > > Sven Vogel > Teamlead Platform > > EWERK DIGITAL GmbH > Brühl 24, D-04109 Leipzig > P +49 341 42649 - 99 > F +49 341 42649 - 98 > s.vo...@ewerk.com > www.ewerk.com > > Geschäftsführer: > Dr. Erik Wende, Hendrik Schubert, Frank Richter > Registergericht: Leipzig HRB 9065 > > Zertifiziert nach: > ISO/IEC 27001:2013 > DIN EN ISO 9001:2015 > DIN ISO/IEC 20000-1:2011 > > EWERK-Blog | LinkedIn | Xing | Twitter | Facebook > > Auskünfte und Angebote per Mail sind freibleibend und unverbindlich. > > Disclaimer Privacy: > Der Inhalt dieser E-Mail (einschließlich etwaiger beigefügter Dateien) ist > vertraulich und nur für den Empfänger bestimmt. Sollten Sie nicht der > bestimmungsgemäße Empfänger sein, ist Ihnen jegliche Offenlegung, > Vervielfältigung, Weitergabe oder Nutzung des Inhalts untersagt. Bitte > informieren Sie in diesem Fall unverzüglich den Absender und löschen Sie > die E-Mail (einschließlich etwaiger beigefügter Dateien) von Ihrem System. > Vielen Dank. > > The contents of this e-mail (including any attachments) are confidential > and may be legally privileged. If you are not the intended recipient of > this e-mail, any disclosure, copying, distribution or use of its contents > is strictly prohibited, and you should please notify the sender immediately > and then delete it (including any attachments) from your system. Thank you. > > Am 14.02.2020 um 13:42 schrieb Andrija Panic <andrija.pa...@gmail.com>: > > > > +1 > > > >> On Fri, 14 Feb 2020 at 13:18, Wido den Hollander <w...@widodh.nl> > wrote: > >> > >> > >> > >>> On 2/14/20 1:03 PM, Daan Hoogland wrote: > >>> devs, I thought I had already sent a mail about this but i cannot find > >> it. > >>> I'm sure i had mentioned it somewhere (probably on github). > >>> this is a follow up on [1] and hopefully you'll agree, a slight > >> improvement. > >>> > >>> here it comes: > >>> > >>> At the moment we are creating PRs with a [WIP] or [DO NOT MERGE] tag in > >> the > >>> title. This title stands the chance of being merged once we agree the > PR > >> is > >>> ready for merge. It also clutters the title. > >>> > >>> Github has introduced a nice feature a while ago; draft PR. When > >> creating a > >>> PR you can opt not to open it for merge but as draft. Choose a button > >> left > >>> of the "Create pull request" button, marked "Create draft PR". It will > >> be a > >>> full PR with all CI and discussion possibilities open. The only > >> difference > >>> is the merge button being disabled. One will than have to make/mark it > >>> "ready for merge" before it *can* be merged. > >>> > >> > >> That sounds like a good idea! Would be a +1 from me :-) > >> > >> Wido > >> > >>> [1] > >>> > >> > https://lists.apache.org/thread.html/f3f0988907f85bfc2cfcb0fbcde831037f9b1cb017e94bcdddd68932%40%3Cdev.cloudstack.apache.org%3E > >>> please shoot any comments you may have back at me, > >>> thanks > >>> > >> > > > > > > -- > > > > Andrija Panić >
