rhtyd commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r450667877
##########
File path: src/components/view/ListView.vue
##########
@@ -61,18 +61,27 @@
-->
<span slot="name" slot-scope="text, record">
- <div style="min-width: 120px">
- <span v-if="$route.path.startsWith('/project')" style="margin-right:
5px">
- <a-button type="dashed" size="small" shape="circle" icon="login"
@click="changeProject(record)" />
- </span>
- <os-logo v-if="record.ostypename" :osName="record.ostypename"
size="1x" style="margin-right: 5px" />
- <console :resource="record" size="small" style="margin-right: 5px" />
+ <div style="min-width: 120px" >
+ <a-popover v-if="actions.length > 0" triggers="hover"
placement="right">
Review comment:
@davidjumani for read-only admin will this hide the name if there is
nothing to be shown? the hover part LGTM but it's not clear perhaps add an
explicit icon; what about components which don't have name column as the first
column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
