davidjumani commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472050809
##########
File path: src/config/section/storage.js
##########
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+ {
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening Could you add a check whether the instance hypervisor is KVM
since the legacy UI only supports it for KVM.
https://github.com/apache/cloudstack/blob/master/ui/scripts/storage.js#L3220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
