rhtyd commented on a change in pull request #587:
URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472807049
##########
File path: src/config/section/storage.js
##########
@@ -325,6 +326,16 @@ export default {
details: ['name', 'id', 'displayname', 'description', 'type', 'current',
'parentName', 'virtualmachineid', 'account', 'domain', 'created'],
searchFilters: ['name', 'domainid', 'account', 'tags'],
actions: [
+ {
+ api: 'createSnapshotFromVMSnapshot',
+ icon: 'camera',
+ label: 'label.action.create.snapshot.from.vmsnapshot',
+ message: 'message.action.create.snapshot.from.vmsnapshot',
+ dataView: true,
+ popup: true,
+ show: (record) => { return record.state === 'Ready' },
Review comment:
@ravening @davidjumani can we make it simpler then? maybe change the
list response to pass hypervisor and use it here. Note: 1.0/GA ships with 4.15
- so if it makes it simpler, send a PR against 4.14 branch and return the key
as part of vmsnapshot list response?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
