davidjumani commented on a change in pull request #880:
URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534028919
##########
File path: src/views/storage/TakeSnapshot.vue
##########
@@ -181,10 +181,9 @@ export default {
catchMessage: this.$t('error.fetching.async.job.result')
})
}
- this.closeAction()
}).catch(error => {
this.$notifyError(error)
- })
+ }).finally(() => { this.closeAction() })
Review comment:
The error is that `this.actionLoading` is not reset. Would be better to
set it back to false in finally so the user can try creating the snapshot again
in case of a failure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
