davidjumani commented on a change in pull request #880:
URL: https://github.com/apache/cloudstack-primate/pull/880#discussion_r534073614
##########
File path: src/views/storage/TakeSnapshot.vue
##########
@@ -181,10 +181,9 @@ export default {
catchMessage: this.$t('error.fetching.async.job.result')
})
}
- this.closeAction()
}).catch(error => {
this.$notifyError(error)
- })
+ }).finally(() => { this.closeAction() })
Review comment:
The form should remain open in case of an error so the user can try
again without having to input all the fields all over again. It closes as
expected if it is successful
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
