Sylvain Wallez wrote:
Done: the selection list builders are now pluggable components. And I also wrote the FlowJXPathSelectionList just to test if this worked properly...

In the back of my mind I'm a little sad because you took away from me the possibility of making a first, substantial commit ;-).


Is this what you had also? If not feel free to hack and patch around!

I have a couple of observations just from quickly glancing at your code:


Shouldn't this component be called just JXPathSelectionList? There's no reason why it should be called from the Flow only, is there?

In my code I mimicked what DynamicSelectionList does, namely wrapping the ContentHandler in a SelectionListHandler that does some datatype conversions, AFAIU. Isn't the same needed here?

What about tests? ;-)

That's all for now. I hope do have a deeper look at the code later, and maybe write some tests and docs.

Thanks a lot,

Ugo



--
Ugo Cei - Consorzio di Bioingegneria e Informatica Medica
P.le Volontari del Sangue, 2 - 27100 Pavia - Italy
Phone: +39.0382.525100 - E-mail: [EMAIL PROTECTED]



Reply via email to