Unico Hommes wrote:
Sylvain Wallez wrote:
Unico Hommes wrote:
<snip/>
I just had a look at the code, seems it was already a FIXME on Sylvain's list. Can I go ahead and make this change?
Uh? Where's that list??
CallFunctionNode.java ln 166/184: // FIXME (SW) : is a flow allowed not to redirect ?
;-D
Uh (again)? I'm wondering if there's not a misunderstanding here: this FIXME is about knowing if a flowscript is allowed to terminate without stating what page it to be displayed, i.e. check if one of sendPage(), sendPageAndWait() or redirectTo() was called.
I think that flow should cover as many features of the actions as possible, and for this, it should be allowed not to redirect (as actions are allowed to do):
<map:call method="doSomething"/> <map:generate/> <map:transform/> <map:serialize/>
Can we remove this comment now? :)
Vadim
