Joerg Heinicke wrote:
> 
> > Yeah, the confusion with the memory bug was partly due to me. After 
> > your original fix that still had a problem with the reader I 
> > introduced the bug again when I tried to fix that.
> 
> So the lastconsumer null test really works, you only broke it 
> with your reader fix. I guess you have to stand a beer to Carsten :)
> 
Yuppi!

> And we all have not reviewed the patch correctly as the 
> problem is obvious:
> 
> if (lc == null) {
>    lc = anObject;
> }
> 
> if (lc != null) {
>    //always true
>    //executing code introducing memory leak in special cases }
> 
> Shame on all of us ;) Maybe we all have to stand a beer to 
> Carsten at next CocoonGetTogether as the release is rescued.
> 
Yes, yes, yes! Hmm, let me think, we will have approx. 150 attendees
for two days, that makes 75 beers for me per day. I think, that's ok.

So, +1 Joerg :)

Carsten

Reply via email to