Re: onSubmit Handlers and Ajax

[Jeremy Quinn]

On 28 Dec 2006, at 15:16, Carsten Ziegeler wrote:

Hmm,

I'm not sure - I haven't used onSubmit handlers so far as they did not
work with multiple forms :) So we are currently using our own handler
"implementation".

Well hopefully this will be solved :)

We mainly use them for client-site prevalidation like

stop after the first failing handler.

checking for required fields etc. In this case I think it makes sense to

If I understand you correctly, I think I would prefer all pre- validation to occur even if there are validation errors found, otherwise user needs to fix-submit, fix-submit etc. to 'discover' the errors one by one. I would rather see all validation errors in one go.

So I think the current behaviour is fine :) But perhaps there are other use cases? What about a chain implementation? So a handler can decide to

call the next handler or not?

Eeek! ;)

You have a usecase for this ?

Should an onSubmit Handler know if others exist ?


Convince me ;)




best regards

Jeremy

This is going to mean more api changes and more incompatibility issues for people with custom widgets. :( And BTW. Can you think why onSubmit Handlers should no longer be called before Ajax submits (the original question) ?

Jeremy Quinn wrote:

Hi All

Another question ....

Currently, when onSubmit Handers are called, they are able to stop
the form submit by returning false. OK so far.

However, if you have multiple handlers and say the middle one returns
false, the ones after it, do not get called at all.

Is this the right behaviour? Or should all handlers be always called,
returning false if one (or more) of them returns false.

i.e. onSubmit Handers should still be able to stop the form from
submitting, but they should not be able to stop subsequent handers
from being called.

WDYT ?

thanks

regards Jeremy


On 27 Dec 2006, at 18:14, Jeremy Quinn wrote:

Hi All

In 2.1.8, we called forms_onsubmitHandlers when Ajax forms were
submitted.


I do not remember why this was done.

Anybody ?

thanks

regards Jeremy

In 2.1.9 we stopped doing that and only called them on non-Ajax forms.

--
Carsten Ziegeler - Chief Architect
http://www.s-und-n.de
http://www.osoco.org/weblogs/rael/

smime.p7s
Description: S/MIME cryptographic signature