Grzegorz Kossakowski wrote:
Reinhard Pötz pisze:
Grzegorz Kossakowski wrote:
Reinhard Pötz pisze:

I had a brief look at the link-rewrite block and think now that the migration of the LinkrewriterTransformer will be difficult because of its configuration can't be easily converted to Spring.

What kind of obstacles you can see here?

What's your suggestion for a configuration like this:

<map:transformer name="linkrewriter" src="org.apache.cocoon.transformation.LinkRewriterTransformer">
  <input-module name="book-raw">
<file src="cocoon://samples/linkrewriter/bookdemo/linkmap" reloadable="true" />
  </input-module>
  <input-module name="book">
    <input-module name="book-raw">
      <file src="{src}" reloadable="true" />
    </input-module>
    <prefix>//[EMAIL PROTECTED]'</prefix>
    <suffix>']/@href</suffix>
  </input-module>
</map:transformer>

I have no suggestion but only to remove support for such stuff. These days, when you define components as Spring beans you don't need to support configuration passed from one component to another. At least I don't see any need for supporting that kind of configuration.

If we remove this, then of course we'll have to release 2.0 of link rewriter block but I have no problem with it.

I agree with you that we shouldn't support such stuff but what features do we want to see in a new LinkRewriteTransformer? (... hence my suggestion that we start with a ServletLinkRewriteTransformer because we know that we need it.)


--
Reinhard Pötz                           Managing Director, {Indoqa} GmbH
                         http://www.indoqa.com/en/people/reinhard.poetz/

Member of the Apache Software Foundation
Apache Cocoon Committer, PMC member                  [EMAIL PROTECTED]
________________________________________________________________________

Reply via email to