Oh, you're right :-) I only read your mail on the mailing list, not the
complete issue text.
Joerg
On 05.12.2009 11:04, Jos Snellings wrote:
That is what I did.
On Sat, 2009-12-05 at 09:50 +0000, Jörg Heinicke (JIRA) wrote:
[ https://issues.apache.org/jira/browse/COCOON3-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786368#action_12786368 ]
Jörg Heinicke commented on COCOON3-46:
--------------------------------------
Isn't it more convenient if closeQuietly(..) just handles null?
URLConnectionUtils.closeQuietly() complains loudly if servletConnection == null
-------------------------------------------------------------------------------
Key: COCOON3-46
URL: https://issues.apache.org/jira/browse/COCOON3-46
Project: Cocoon 3
Issue Type: Improvement
Components: cocoon-pipeline
Affects Versions: 3.0.0-alpha-2
Reporter: Jos Snellings
Assignee: Cocoon Developers Team
Priority: Minor
Fix For: 3.0.0-alpha-3
finally clause in URLResponse method execute()
contains call to URLConnectionUtils.closeQuietly.
If servletConnection = this.url.openConnection(); fails, servletConnection is
null.
In that case closeQuietly causes a stacktrace to be output.
Solution is if (servletConnection != null)
URLConnectionUtils.closeQuietly(servletConnection);, guard the call with a test,
or even better, take into account in closeQuietly that the input parameter may
be null.
