[
https://issues.apache.org/jira/browse/COCOON3-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788132#action_12788132
]
Steven Dolg commented on COCOON3-46:
------------------------------------
All the patch does is introduce a null check for closeQuietly(..).
Feels like the right thing to do.
Applied with minor formatting changes.
> URLConnectionUtils.closeQuietly() complains loudly if servletConnection ==
> null
> -------------------------------------------------------------------------------
>
> Key: COCOON3-46
> URL: https://issues.apache.org/jira/browse/COCOON3-46
> Project: Cocoon 3
> Issue Type: Improvement
> Components: cocoon-pipeline
> Affects Versions: 3.0.0-alpha-2
> Reporter: Jos Snellings
> Assignee: Steven Dolg
> Priority: Minor
> Fix For: 3.0.0-alpha-3
>
> Attachments: closeQuietly-fix.patch
>
>
> finally clause in URLResponse method execute()
> contains call to URLConnectionUtils.closeQuietly.
> If servletConnection = this.url.openConnection(); fails, servletConnection
> is null.
> In that case closeQuietly causes a stacktrace to be output.
> Solution is if (servletConnection != null)
> URLConnectionUtils.closeQuietly(servletConnection);, guard the call with a
> test,
> or even better, take into account in closeQuietly that the input parameter
> may be null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
