2011/5/14 Simone Tripodi <simonetrip...@apache.org>: > Hi all guys, > OGNL code is formatted using a mixture of various styles, I hope > everybody agrees on adopting one unique style. > I propose to adopt the Maven Style[1] that is already widely adopted > and supported by IDEs. > Thoughts? Objections? If agree I would quickly proceed, just let me know! > SImo > > [1] http://maven.apache.org/developers/conventions/code.html >
-0 (not binding) 1. "Blocks: Always enclose with a new line brace." wastes lines if you want to print the sources. 2. "White space: One space after control statements and between arguments (i.e. if ( foo ) instead of if(foo)), myFunc( foo, bar, baz ) instead of myFunc(foo,bar,baz))." I think that is ugly. Is there a reason behind this? 3. "Line wrapping: Always use a 120-column line width for Java code and Javadoc." Line width of 120 is likely cause line wrapping when diffs are send through e-mail and problems when doing side-by-side comparison. I am not so worried about Java code, as lengthy statements are rare, but more about Javadoc. My personal preference is "Java conventions", but with spaces instead of tabs. Are there any projects in Commons that already use the "Maven" style? Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
