Hi Maurizio! indeed, sometimes such style makes me smile because brings back old memories :) Well, I was too young at '90 to program - anyway I was a SuperMario champion - but my professors at University used that style :P
Jokes a part, I thought that code style was a trivial topic, but at this point a vote makes sense, to find a general consensus. Thanks!!! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Mon, May 16, 2011 at 9:54 AM, Maurizio Cucchiara <maurizio.cucchi...@gmail.com> wrote: > Phil probably hit the nail on the head: contributors might have > problem to incorporate patches, the main risk is that every patch > contain a lot of noise and it's not good for the sake of reviewing. > I have no problem with most of the conventions (which are the default > settings of IntelliJ IIRC). > The only one that I don't like so much is the new line brace. It take > me back to 1990 when I used to code in C. > What about if we put to the vote it between ognl committers? > > On 16 May 2011 00:02, Phil Steitz <phil.ste...@gmail.com> wrote: >> On 5/15/11 2:44 PM, Konstantin Kolinko wrote: >>> 2011/5/14 Simone Tripodi <simonetrip...@apache.org>: >>>> Hi all guys, >>>> OGNL code is formatted using a mixture of various styles, I hope >>>> everybody agrees on adopting one unique style. >>>> I propose to adopt the Maven Style[1] that is already widely adopted >>>> and supported by IDEs. >>>> Thoughts? Objections? If agree I would quickly proceed, just let me know! >>>> SImo >>>> >>>> [1] http://maven.apache.org/developers/conventions/code.html >>>> >>> -0 (not binding) >>> >>> 1. "Blocks: Always enclose with a new line brace." wastes lines if you >>> want to print the sources. >>> >>> 2. "White space: One space after control statements and between >>> arguments (i.e. if ( foo ) instead of if(foo)), myFunc( foo, bar, baz >>> ) instead of myFunc(foo,bar,baz))." >>> >>> I think that is ugly. Is there a reason behind this? >>> >>> 3. "Line wrapping: Always use a 120-column line width for Java code >>> and Javadoc." >>> >>> Line width of 120 is likely cause line wrapping when diffs are send >>> through e-mail and problems when doing side-by-side comparison. I am >>> not so worried about Java code, as lengthy statements are rare, but >>> more about Javadoc. >>> >>> My personal preference is "Java conventions", but with spaces instead of >>> tabs. >>> >>> Are there any projects in Commons that already use the "Maven" style? >> >> I don't think so. I agree with your comments, Konstantin, as do >> most current Commons sources. Our convention here is that >> components maintain their own checkstyle configs and those actively >> working on components determine how they want the sources to look. >> So it comes down to a question for the [ognl] committers to decide. >> One point to consider is that strange settings (and I would >> personally call at least 1 and 2 above "strange") may make it harder >> for new contributors to get involved and for committers to evaluate >> and incorporate patches. >> >> Phil >>> >>> Best regards, >>> Konstantin Kolinko >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > > > -- > Maurizio Cucchiara > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
