On Tue, Mar 13, 2012 at 02:27:32PM +0100, Torsten Curdt wrote: > > CheckStyle reports should be checked regularly. Only doing so just before a > > release indeed leads to a lot of tedious work, because coders did not > > respect the basic, agreed on, style. > > I guess we are disagreeing here.
I didn't think we disagreed on refusing to spend a lot of time of correcting formatting mess. > > > I don't use an IDE, so for me, CheckStyle helps but formatter IDE plugins > > would not. Our mileage do vary but the end-product (clean code) should not. > > Then you are probably a vocal minority here. Because I don't use an IDE or because I like clean code? > As long as there is someone that can run a code formatter before a > release that does not matter though. But would you be against running a formatter before committing the code. "Modern" editors would do this as you type (like e.g. in emacs or the IDE plugins referred to in this thread). It's tiresome to have to read badly formatted code and it leads to spurios commits just to straighten up the formatting. > > As said in another post, you can always disable reports that you find > > unhelpful. > > Fair enough. But projects that find it useful could also just add the report > :) > We are discussing about what should be the default here. > That said I rather just disable it in the POM that continue with the > discussion. > > >> The basic code style is like logging - people spent just wait too much > >> time on this. > > ...because I dont' want to contribute to that time any more. > > > The real problem is that some coders do not do their part of the job when > > they commit badly formatted code. > > Those whose spend too much time are the ones who try to clean up the mess > > afterwards. > > If you prefer to not use code formatter - that is. But that's your decision. Did I say so? I just said the opposite: I don't like that people commit badly formatted code and... > Menu > "Format Source Code" > Done. ... if they don't perform the above, CheckStyle is there to remind them they forgot to do it. > ...plus I am bet there are ways to set up code formatting for vim and > friends - if one wanted to. I hope that misunderstanding has been cleared now. > > CheckStyle indeed points a finger to the right person, which IMHO helps by > > making this person aware that he should fix it. > > And I say - better let's give people the tools and not just point at them. The tools are there, but you have to tell people that they _must_ use them. Regards, Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
