On Wed, Dec 19, 2012 at 10:14:58PM +0100, Luc Maisonobe wrote: > Le 19/12/2012 22:04, Gary Gregory a écrit : > > On Wed, Dec 19, 2012 at 3:10 PM, Luc Maisonobe <luc.maison...@free.fr>wrote: > > > >> Le 19/12/2012 11:03, Gilles Sadowski a écrit : > >>> Hi. > >>> > >>> Please have a look at the latest candidate (RC4), and vote for the > >> release > >>> of Commons Math 3.1. > >>> > >>> ---------- > >>> Tag: > >>> > >> https://svn.apache.org/repos/asf/commons/proper/math/tags/MATH_3_1_RC4/ > >>> > >>> Site: > >>> http://people.apache.org/builds/commons/math/3.1/RC4/ > >>> > >>> Binaries: > >>> > >> https://repository.apache.org/content/repositories/orgapachecommons-048/org/apache/commons/commons-math3/3.1/ > >>> > >>> [X] +1 Release it. > >> > >> There are a few missing headers, but only in test files, so I don't > >> think it is a blocker. > >> > > > > I'm not so sure, missing headers on .java are a must IMO. > > I have fixed them in trunk, as well as a few checkstyle errors I missed > earlier.
The CheckStyle warnings were probably a consequence of fixing the Clirr errors. Do we stand with your previous statement that missing headers on test files were not a blocker? IIRC, this was the conclusion for release 3.0. Those headers have been missing for a long time. The JIRA report will avoid that for next time. Gilles > Luc > > > > > I commented earlier about .properties files. For .csv, it depends on your > > parser. > > > > Gary > > > > > >> Luc > >> > >>> [ ] +0 Go ahead; I don't care. > >>> [ ] -0 There are a few minor glitches: ... > >>> [ ] -1 No, do not release it because ... > >>> > >>> This vote will close in 72 hours. > >>> ---------- > >>> > >>> > >>> Thanks, > >>> Gilles > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
