Le 2015-11-25 07:50, Thomas Neidhart a écrit :
On 11/24/2015 11:30 PM, Jörg Schaible wrote:
Hi Thomas,

Thomas Neidhart wrote:

Hi all,

we have accumulated enough changes since the last 4.0 release as well as
we need to provide a fix for the known remote code exploit via java
de-serialization. Therefore, I would like to start a vote to release
Commons Collections 4.1 based on RC1.

Note:

The fix for the security related issue results in Clirr errors as unsafe
classes in the functor package do not implement the Serializable
interface anymore. This is mentioned in the release notes.


Collections 4.1 RC1 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/collections/
    (svn revision 11263)

Maven artifacts are here:



https://repository.apache.org/content/repositories/orgapachecommons-1122/org/apache/commons/commons-collections4/4.1/

Details of changes since 4.0 are in the release notes:


https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt


http://people.apache.org/builds/commons/collections/4.1/RC1/changes-report.html

The tag is here:



https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_1_RC1
    (svn revision 1715703)

Site:
    http://people.apache.org/builds/commons/collections/4.1/RC1/

Clirr Report (compared to 4.0):


http://people.apache.org/builds/commons/collections/4.1/RC1/clirr-report.html

RAT Report:


http://people.apache.org/builds/commons/collections/4.1/RC1/rat-report.html

KEYS:
    https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.

This vote will close no sooner that 72 hours from now, i.e. after 2400
GMT 25-November 2015

  [ ] +1 Release these artifacts

+1 for the release

Luc

  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thanks,

Thomas

It fails for IBM JDK 6:

================================ %< ===================
Failed tests:
org.apache.commons.collections4.map.AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue(org.apache.commons.collections4.map.AbstractMapTest$TestMapEntrySet)
  Run 1: PASS
  Run 2: PASS
  Run 3: PASS
  Run 4: PASS
  Run 5: PASS
  Run 6: PASS
  Run 7: PASS
  Run 8: PASS
  Run 9: PASS
  Run 10: PASS
  Run 11: PASS
  Run 12: PASS
  Run 13: PASS
  Run 14: PASS
  Run 15: PASS
  Run 16: PASS
  Run 17: PASS
  Run 18: PASS
  Run 19: PASS
  Run 20: PASS
  Run 21: PASS
  Run 22: PASS
  Run 23: PASS
  Run 24: PASS
  Run 25: PASS
  Run 26: PASS
  Run 27: PASS
  Run 28: PASS
  Run 29: PASS
  Run 30: PASS
  Run 31: PASS
  Run 32: PASS
  Run 33: PASS
  Run 34: PASS
  Run 35: PASS
  Run 36: PASS
  Run 37:
AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1665
expected:<true> but was:<false>
  Run 38: PASS
  Run 39: PASS
  Run 40: PASS
  Run 41: PASS
  Run 42:
AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1665
expected:<true> but was:<false>
  Run 43: PASS

These test failures exist since the 4.0 release, quoting your vote for
Collection 4.0 based on RC5:

+1, builds for all but one JDK flawlessly from source. I still have 2
failing tests for IBM JDK 1.6:

Failed tests:
AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1656
expected:<true> but was:<false>
AbstractMapTest$TestMapEntrySet.testMapEntrySetIteratorEntrySetValue:1656
expected:<true> but was:<false>

However, since we already blamed that JDK, it does not influence the
release.

I can not remember anymore why these have not been worked-around though,
but I suspect that it was not so simple in this case.


================================ %< ===================
$ mvn-3.0 -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
14:51:28+0100)
Maven home: /usr/share/maven-bin-3.0
Java version: 1.6.0, vendor: IBM Corporation
Java home: /opt/ibm-jdk-bin-1.6.0.9_p2/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.1.12-gentoo", arch: "amd64", family: "unix"
================================ %< ===================

It fails to compile with Java 8:

================================ %< ===================
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/joehni/tmp/download/commons-collections4-4.1-
src/src/test/java/org/apache/commons/collections4/FluentIterableTest.java:
[242,41] reference to forEach is ambiguous
  both method forEach(java.util.function.Consumer<? super T>) in
java.lang.Iterable and method
forEach(org.apache.commons.collections4.Closure<? super E>) in
org.apache.commons.collections4.FluentIterable match
[INFO] 1 error
[INFO] -------------------------------------------------------------

ok, this error has been already spotted by Oliver and fixed in trunk. It
is only in a test case where the type inference fails when passing a
null value to a method, as you usually do in tests.

================================ %< ===================
$ mvn-3.0 -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
14:51:28+0100)
Maven home: /usr/share/maven-bin-3.0
Java version: 1.8.0_66, vendor: Oracle Corporation
Java home: /opt/oracle-jdk-bin-1.8.0.66/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.1.12-gentoo", arch: "amd64", family: "unix"
================================ %< ===================

nor Java 9:

ok. I have to investigate these errors, but I really wonder what we
should do about it. Java 1.9 is not released yet, and these might be
compiler related bugs that will be fixed, and adding work-arounds for
things that perfectly compile with all previous Java versions does not
sound right.

-1

Sorry,
Jörg

Thanks,

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to