Hi,

Romain Manni-Bucau <rmannibu...@gmail.com> schrieb am Di., 21. Juni 2016 um
11:06 Uhr:

> we would check there is a local address, if not then the test would be
> skipped on that jenkins instance
>

I'm indifferent. I agree with Thomas, that this may be out of scope for the
tests anyway.


>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>
> 2016-06-21 11:02 GMT+02:00 Benedikt Ritter <brit...@apache.org>:
>
> > Romain Manni-Bucau <rmannibu...@gmail.com> schrieb am Mo., 20. Juni 2016
> > um
> > 22:50 Uhr:
> >
> > > JUnit has Assume which can allow to keep the test, wouldn't it be
> better?
> > >
> >
> > What would be the condition of the assume call?
> >
> >
> > >
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> > > <http://www.tomitribe.com> | JavaEE Factory
> > > <https://javaeefactory-rmannibucau.rhcloud.com>
> > >
> > > 2016-06-20 21:22 GMT+02:00 Benedikt Ritter <brit...@apache.org>:
> > >
> > > > Thomas Vandahl <t...@apache.org> schrieb am Mo., 20. Juni 2016 um
> 21:21
> > > Uhr:
> > > >
> > > > > On 19.06.16 10:47, Benedikt Ritter wrote:
> > > > > > Hi,
> > > > > >
> > > > > > we have failing tests on Jenkins for JCS [1]. Does anybody know
> > what
> > > > > caused
> > > > > > this?
> > > > > >
> > > > > > Regards,
> > > > > > Benedikt
> > > > > >
> > > > > > [1]
> > > > > >
> > > > >
> > > >
> > >
> >
> https://builds.apache.org/view/Apache%20Commons/job/commons-jcs/159/org.apache.commons$commons-jcs-core/console
> > > > > >
> > > > >
> > > > > The different systems I have access to do not show this problem. So
> > I'm
> > > > > not able to reproduce it. One of the failing tests hints that there
> > is
> > > > > no site-local address available in the Jenkins system, IOW no
> adapter
> > > > > exists for which inetAddr.isSiteLocalAddress() returns true.
> > > > >
> > > > > Now the question is if that actually should be subject of a library
> > > test
> > > > > at all because it actually tests the correctness of a system
> > > > > configuration and not the library. I'm tempted to remove/disable
> the
> > > > > tests. WDYT?
> > > > >
> > > >
> > > > Sounds reasonable.
> > > >
> > > > Benedikt
> > > >
> > > >
> > > > >
> > > > > Bye, Thomas.
> > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > > > > For additional commands, e-mail: dev-h...@commons.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to