Hi Bruno,The existing array with name "d", at any given instance contains data
meant for only one row in the matrix.My understanding to get the number of
inserts, deletes and substitutes, we need to form the complete matrix and
iterate the diagonal elements to get the values.Considering this I cant use the
existing array "d" to find the inserts, deletes and substitutes.Correct me if I
am wrong in the above.
Do you want me to use a new 1d array (which contains the entire data from the
matrix) instead of 2d array (1d vs 2d, improve in performance?)?
Kindly comment.
Do let me know if i am not clear in the above.
Thank you,
Regards,Don Jeba.
From: don jeba <donj...@yahoo.com>
To: Commons Developers List <dev@commons.apache.org>; Bruno P. Kinoshita
<brunodepau...@yahoo.com.br>
Sent: Tuesday, 25 October 2016 9:15 PM
Subject: Re: [TEXT] TEXT-10 A more complex Levenshtein distance
Hi Bruno, Now the comment on formatting is fixed. I will be careful on
this the next time.
My understanding is, we need to traverse from the diagonal element [right
bottom corner] to find whether whether its insert or delete or substitute. I
might be wrong.
Regarding using 1D array instead of 2D array, I think it should be possible. I
will also give a try.
Thank you,
Regards,Don Jeba.
From: Bruno P. Kinoshita <brunodepau...@yahoo.com.br.INVALID>
To: Commons Developers List <dev@commons.apache.org>; don jeba
<donj...@yahoo.com>
Sent: Monday, 24 October 2016 8:15 AM
Subject: Re: [TEXT] TEXT-10 A more complex Levenshtein distance
Hi Don,
Could you take a look at the tabs/spaces in the pull request, please?
In the meantime, I'll play with the code to see if
i) we can use the two-array algorithm instead; where we analyse two lines each
time, instead of keeping the whole matrix. Will probably have to compute the
LevenshteinResults on-the-fly for that, instead of in a separate method.
ii) check if it would be doable to use the one array + temporary variables algo
instead, and also compute the insert+delete+substitute on the fly.
Just need a couple of hours to play with the code and run your tests to make
sure it is working :)
Cheers
Bruno
>________________________________
> From: don jeba <donj...@yahoo.com.INVALID>
>To: Commons Developers List <dev@commons.apache.org>; Bruno P. Kinoshita
><brunodepau...@yahoo.com.br>
>Sent: Monday, 17 October 2016 11:44 PM
>Subject: Re: [TEXT] TEXT-10 A more complex Levenshtein distance
>
>
>Hi Bruno,
>Thank you for the review.
>The one in lang gets only the distance (insert+delete+substitute). To get the
>individual values, (my understanding is), I need to iterate the diagonal
>elements in matrix, also need to know the elements at the left and top of the
>diagonal element to find whether its an insertion or deletion or substitution.
>Considering this I have used 2 dimensional array.
>Regards,
>Don Jeba.
>
> From: Bruno P. Kinoshita <brunodepau...@yahoo.com.br.INVALID>
>
>To: Commons Developers List <dev@commons.apache.org>; don jeba
><donj...@yahoo.com>
>Sent: Monday, 17 October 2016 7:37 AM
>Subject: Re: [TEXT] TEXT-10 A more complex Levenshtein distance
>
>Hi Don Jeba,
>
>I will have a look at your implementation to compare with a recent improvement
>in [lang]
>https://github.com/apache/commons-lang/blob/78134f6b3f1facd019e604d2cd000c4ce7cf9a0a/src/main/java/org/apache/commons/lang3/StringUtils.java#L7710
>
>Instead of keeping a matrix (or even only two rows) the current version in
>StringUtils keeps just one array and a couple of helper temporary variables.
>
>Not sure if we can re-use it, adding the new features in TEXT-10 (i.e.
>insert/delete/substitution counts), but if possible that'd be better.
>
>Cheers
>Bruno
>
>
>
>
>----- Original Message -----
>> From: don jeba <donj...@yahoo.com.INVALID>
>> To: Commons Developers List <dev@commons.apache.org>
>> Sent: Monday, 17 October 2016 1:51 AM
>> Subject: [TEXT] TEXT-10 A more complex Levenshtein distance
>>
>> Hello, I am new to open source contribution.
>> Lately I gave a pull request to common-text. I dont know whether I am
>> missing
>> any procedure to contribute to common-text. Kindly correct me so that I can
>> do
>> the necessary so that someone will review and comment on my code.
>> Jira TEXT-10
>>
>> https://github.com/apache/commons-text/pull/6
>>
>> Kindly advise.
>> Thank you,
>> Regards,Don Jeba.
>>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>For additional commands, e-mail: dev-h...@commons.apache.org
>
>
>
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
