My vote: +1 (binding) Looking good!
Checked: +1 commit matches tag (even signed tag, yay!) +0 commit matches src (git tag is missing "<createChecksum>true</createChecksum>" -- why?) +0 src matches staging repo -sources (hard to check as *-src.tar.gz was not staged :-( ) +1 bin JARs matches staging repo hashes +1 zip vs tar.gz +1 .asc signatures of dist and repo +1 md5/sha1 hashes (email's hash filenames says .sha1, but match correctly the zip/tar.gz) +0 mvn apache-rat:check (exceptions are already excluded for <reporting>) +1 no unexpected binaries +1 mvn clean install +1 .. and afterwards in commons-rng-examples +0 binary vs source (binary adds commons-rng-examples-1.0.jar, built separately in source) +1 RELEASE-NOTES +1 LICENSE, NOTICE +1 site (minor markdown highlight bug "64 bits" at http://home.apache.org/~erans/commons-rng-1.0-RC5-site/userguide/rng.html) +1 javadoc On 30 November 2016 at 00:08, Gilles <gil...@harfang.homelinux.org> wrote: > Hi. > > This is a [VOTE] for releasing Apache Commons RNG 1.0 (from RC5). > > Main changes wrt the preceding vote (RC2, on September 16) are: > * Modularization > * Non-uniform deviates (in module "commons-rng-sampling") > > > Tag name: > RNG_1_0_RC5 (signature can be checked from git using 'git tag -v') > > Tag URL: > > https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=commit;h=f9de6401e981554c3f44936c2272429e290fdbec > > Commit ID the tag points at: > f9de6401e981554c3f44936c2272429e290fdbec > > Site: > http://home.apache.org/~erans/commons-rng-1.0-RC5-site > > Distribution files: > https://dist.apache.org/repos/dist/dev/commons/rng/ > > Distribution files hashes (SHA1): > de2a54518a0ef10ba5a2be1c3b060a441f4466e2 commons-rng-1.0-bin.tar.gz.sha1 > cfcfde1f65dec9c30be1273ff2237d551eb87933 commons-rng-1.0-bin.zip.sha1 > 6d529de9418314066727a7d5ada88dd87dc0163d commons-rng-1.0-src.tar.gz.sha1 > 561dd3e5ebf53d60e883d5c04e543f58374c45b6 commons-rng-1.0-src.zip.sha1 > > KEYS file to check signatures: > http://www.apache.org/dist/commons/KEYS > > Maven artifacts: > https://repository.apache.org/content/repositories/orgapachecommons-1225/ > > > [ ] +1 Release it. > [ ] +0 Go ahead; I don't care. > [ ] -0 There are a few minor glitches: ... > [ ] -1 No, do not release it because ... > > This vote will close in 72 hours, at 2016-12-03T00:00:00Z (this is UTC > time). > ---------- > > > Thanks, > Gilles > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > -- Stian Soiland-Reyes http://orcid.org/0000-0001-9842-9718 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
