+1

Thank you for preparing the RC.

ASC, MD5, SHA1 OK.

RAT check OK

CLIRR check OK

'mvn clean verify site' OK

Generated site is OK. I am not sure why there is a JaCoCo aggregate report
which shows nothing useful but that is not a blocker.

I would be nice to have a BUILDING.md file like some other components do
but not a blocker.

It would also be nice to publish the next version of commons-parent to pick
new versions of plugin but again, not a blocker.

Tested 'mvn clean verify site' with 'set MAVEN_OPTS=-Xmx2000m
-XX:MaxPermSize=384m' for Java 7:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T13:39:06-06:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

Also OK with Java 8:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T13:39:06-06:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_144\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

As expected, the horror that is Java 9 leads to problems:

Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T13:39:06-06:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 9, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk-9
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

java version "9"
Java(TM) SE Runtime Environment (build 9+181)
Java HotSpot(TM) 64-Bit Server VM (build 9+181, mixed mode)

Tests run: 84, Failures: 0, Errors: 6, Skipped: 8, Time elapsed: 5.156 sec
<<< FAILURE! - in org.apache.commons.csv.CSVPrinterTest
testHeaderCommentTdf(org.apache.commons.csv.CSVPrinterTest)  Time elapsed:
0.001 sec  <<< ERROR!
java.util.ServiceConfigurationError:
sun.util.locale.provider.LocaleDataMetaInfo: Provider
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo could not be
instantiated
        at
org.apache.commons.csv.CSVPrinterTest.printWithHeaderComments(CSVPrinterTest.java:154)
        at
org.apache.commons.csv.CSVPrinterTest.testHeaderCommentTdf(CSVPrinterTest.java:473)
Caused by: java.lang.IllegalAccessError: Update to static final field
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo.$jacocoData
attempted from a different method ($jacocoInit) than the initializer method
<clinit>
        at
org.apache.commons.csv.CSVPrinterTest.printWithHeaderComments(CSVPrinterTest.java:154)
        at
org.apache.commons.csv.CSVPrinterTest.testHeaderCommentTdf(CSVPrinterTest.java:473)

testPrintRecordsWithResultSetOneRow(org.apache.commons.csv.CSVPrinterTest)
 Time elapsed: 0.123 sec  <<< ERROR!
java.lang.IllegalAccessError: Update to static final field
java.sql.SQLException.$jacocoData attempted from a different method
($jacocoInit) than the initializer method <clinit>
        at
org.apache.commons.csv.CSVPrinterTest.testPrintRecordsWithResultSetOneRow(CSVPrinterTest.java:1282)

testJdbcPrinterWithResultSetMetaData(org.apache.commons.csv.CSVPrinterTest)
 Time elapsed: 0.015 sec  <<< ERROR!
java.lang.IllegalAccessError: Update to static final field
java.sql.DriverManager.$jacocoData attempted from a different method
($jacocoInit) than the initializer method <clinit>
        at
org.apache.commons.csv.CSVPrinterTest.testJdbcPrinterWithResultSetMetaData(CSVPrinterTest.java:528)

testJdbcPrinterWithResultSet(org.apache.commons.csv.CSVPrinterTest)  Time
elapsed: 0 sec  <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.h2.Driver
        at
org.apache.commons.csv.CSVPrinterTest.testJdbcPrinterWithResultSet(CSVPrinterTest.java:513)

testJdbcPrinter(org.apache.commons.csv.CSVPrinterTest)  Time elapsed: 0 sec
 <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.h2.Driver
        at
org.apache.commons.csv.CSVPrinterTest.geH2Connection(CSVPrinterTest.java:134)
        at
org.apache.commons.csv.CSVPrinterTest.testJdbcPrinter(CSVPrinterTest.java:500)

testHeaderCommentExcel(org.apache.commons.csv.CSVPrinterTest)  Time
elapsed: 0 sec  <<< ERROR!
java.util.ServiceConfigurationError:
sun.util.locale.provider.LocaleDataMetaInfo: Provider
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo could not be
instantiated
        at
org.apache.commons.csv.CSVPrinterTest.printWithHeaderComments(CSVPrinterTest.java:154)
        at
org.apache.commons.csv.CSVPrinterTest.testHeaderCommentExcel(CSVPrinterTest.java:462)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class
sun.util.resources.cldr.provider.CLDRLocaleDataMetaInfo
        at
org.apache.commons.csv.CSVPrinterTest.printWithHeaderComments(CSVPrinterTest.java:154)
        at
org.apache.commons.csv.CSVPrinterTest.testHeaderCommentExcel(CSVPrinterTest.java:462)

Gary

On Sun, Aug 27, 2017 at 4:10 AM, Bruno P. Kinoshita <
brunodepau...@yahoo.com.br.invalid> wrote:

> Hello all,
>
> This is a [VOTE] for releasing Apache Commons CSV 1.5 (from RC1).
>
> Tag name:
>   csv-1.5-RC1 (signature can be checked from git using 'git tag -v')
> Tag URL:
>   https://git-wip-us.apache.org/repos/asf?p=commons-csv.git;a=commit;h=
> f76a1357057cd3caaf9b0904d9cc57ce384658a3
> Commit ID the tag points at:
>   f76a1357057cd3caaf9b0904d9cc57ce384658a3
>
> Site:
>   http://people.apache.org/~kinow/commons-csv-1.5-RC1/
> Distribution files (committed at revision 21311):
>   https://dist.apache.org/repos/dist/dev/commons/csv/
>
> Distribution files hashes (SHA1):
>   commons-csv-1.5-bin.tar.gz
>   (SHA1: 4c2a4cde27c556f808c9999d354807579a208fcf)
>   commons-csv-1.5-bin.zip
>   (SHA1: fea9c15a06e1f660b2bba30a5fba44a76492c02e)
>   commons-csv-1.5-src.tar.gz
>   (SHA1: e2c83f040fdfdb868184c019624d20b79113e004)
>   commons-csv-1.5-src.zip
>   (SHA1: 22f009e0e7be51c3c61fa667c02ac1822276c7b8)
>
> These are the Maven artifacts and their hashes:
>   commons-csv-1.5-javadoc.jar
>   (SHA1: 8008b611f677b9ba06988e8102887fa4caed93b5)
>   commons-csv-1.5-sources.jar
>   (SHA1: b76c277916ffef14d63279b896b6a82252ddeb79)
>   commons-csv-1.5-test-sources.jar
>   (SHA1: f7771a23ac6ec7d5183c65146135e51f6bf2c8fb)
>   commons-csv-1.5-tests.jar
>   (SHA1: 1209d9e86a83ac06d139ea02c4331a1426051ee7)
>   commons-csv-1.5.jar
>   (SHA1: e10f140af5b82167640f254fa9d88e35ad74329c)
>   commons-csv-1.5.pom
>   (SHA1: cffa8d9814f6d711a3cb57865e65927b1f54dcb0)
>
> KEYS file to check signatures:
>   http://www.apache.org/dist/commons/KEYS
>
> Maven artifacts:
>   https://repository.apache.org/content/repositories/orgapachecommons-1257
> Please select one of the following options[1]:
>
>   [ ] +1 Release it.
>   [ ] +0 Go ahead; I don't care.
>   [ ] -0 There are a few minor glitches: ...
>   [ ] -1 No, do not release it because ...
>
> This vote will be open at least 72 hours, i.e. until 2017-08-30T10:00:00Z
> (this is UTC time).
> --------
>
> Cheers,
>
> -Bruno
>
> [1] http://apache.org/foundation/voting.html
> ps: I submitted this vote e-mail before at 06:00:00 UTC, but looks like
> the e-mail did not go through, so waited some hours before sending it again
>

Reply via email to