On 13 February 2018 at 09:31, Gilles <gil...@harfang.homelinux.org> wrote:
> On Tue, 13 Feb 2018 00:16:13 +0000 (UTC), st...@apache.org wrote:
>>
>> Repository: commons-csv
>> Updated Branches:
>>   refs/heads/CSV-216 637ad2d7a -> f66a83901
>>
>>
>> CSV-216: Avoid Arrays.copyOf()
>
>
> Why?

Agreed

>> as .clone() will do
>
>
> We should rather avoid using "clone()".

Again: why?

It's not clear why Arrays.copyOf(0 is considered bad, nor why clone()
is considered bad.

> Gilles
>
>
>> -- at least until someone tries to do
>> .withValue(x) in an out-of-range column
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/commons-csv/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/commons-csv/commit/f66a8390
>> Tree: http://git-wip-us.apache.org/repos/asf/commons-csv/tree/f66a8390
>> Diff: http://git-wip-us.apache.org/repos/asf/commons-csv/diff/f66a8390
>>
>> Branch: refs/heads/CSV-216
>> Commit: f66a83901bd026369a2e8d522bd567eb2ef3f8c0
>> Parents: 637ad2d
>> Author: Stian Soiland-Reyes <st...@apache.org>
>> Authored: Fri Feb 9 16:49:51 2018 +0000
>> Committer: Stian Soiland-Reyes <st...@apache.org>
>> Committed: Tue Feb 13 00:14:52 2018 +0000
>>
>>
>> ----------------------------------------------------------------------
>>  src/main/java/org/apache/commons/csv/CSVRecord.java | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> ----------------------------------------------------------------------
>>
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/commons-csv/blob/f66a8390/src/main/java/org/apache/commons/csv/CSVRecord.java
>>
>> ----------------------------------------------------------------------
>> diff --git a/src/main/java/org/apache/commons/csv/CSVRecord.java
>> b/src/main/java/org/apache/commons/csv/CSVRecord.java
>> index 979119f..2be5c49 100644
>> --- a/src/main/java/org/apache/commons/csv/CSVRecord.java
>> +++ b/src/main/java/org/apache/commons/csv/CSVRecord.java
>> @@ -199,7 +199,7 @@ public class CSVRecord implements Serializable,
>> Iterable<String> {
>>      public final CSVRecord immutable() {
>>         if (isMutable()) {
>>                 // Subclass is probably CSVMutableRecord, freeze values
>> -               String[] frozenValue = Arrays.copyOf(values,
>> values.length);
>> +               String[] frozenValue = values.clone();
>>                 return new CSVRecord(frozenValue, mapping, comment,
>> recordNumber, characterPosition);
>>         } else {
>>                 return this;
>> @@ -260,7 +260,7 @@ public class CSVRecord implements Serializable,
>> Iterable<String> {
>>         if (isMutable()) {
>>                 return this;
>>         }
>> -               String[] newValues = Arrays.copyOf(values, values.length);
>> +               String[] newValues = values.clone();
>>         return new CSVMutableRecord(newValues, mapping, comment,
>> recordNumber, characterPosition);
>>         }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to