On Fri, 16 Feb 2018 20:11:11 +0100, Gilles <gil...@harfang.homelinux.org> wrote:
> Bottom-line: Don't use clone except to copy arrays.
> So I'd rephrase my comment on the commit: let "clone()" in place
> but with the comment that it's the only acceptable use of it.

OK, I've added such comments :)

(It was also used for copying the headers, which was also String[])

-- 
Stian Soiland-Reyes
The University of Manchester
http://www.esciencelab.org.uk/
http://orcid.org/0000-0001-9842-9718


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to