Before I vote on the the thread, does adding a method to an interface cause BC to break? I would think not. All of the clirr errors are merely additions. Further the JAPICMP report confirms this.
I’m validating the remainder of the release now, and wanted to ask the above question before adding in my vote. Cheers, -Rob > On Jan 27, 2019, at 7:45 AM, Maxim Solodovnik <solomax...@gmail.com> wrote: > > Thanks a million! > > On Sun, 27 Jan 2019 at 00:07, Rob Tompkins <chtom...@gmail.com> wrote: > >> Sure. >> >> I cloned down your tag, added these lines to the pom.xml: >> >> https://github.com/apache/commons-text/blob/master/pom.xml#L59-L63 >> >> and >> >> https://github.com/apache/commons-text/blob/master/pom.xml#L132-L138 >> (except just in the plugins part of the build section) >> >> then you run >> mvn japicmp:cmp >> >> I couldn’t get the report to work, but that put something in the target >> directory that’s an html file. I then opened it in the browser and >> converted it to a pdf for the sake of sending it to the ML. >> >> -Rob >> >>> On Jan 25, 2019, at 11:33 PM, Maxim Solodovnik <solomax...@gmail.com> >> wrote: >>> >>> Hello Rob, >>> >>> can you please share brief how-to, so I can regenerate the report? :) >>> >>> On Sat, 26 Jan 2019 at 02:04, Rob Tompkins <chtom...@gmail.com> wrote: >>> >>>> Just an FYI, I hacked this together for the sake of reporting on >> solomax’s >>>> work: >>>> >>>> Cheers, >>>> -Rob >>>> >>>> >>>> >>>>> On Jan 20, 2019, at 8:48 AM, Gary Gregory <garydgreg...@gmail.com> >>>> wrote: >>>>> >>>>> We might as well start with releasing fresh versions of our internal >>>> maven >>>>> plugins, then commons-parent, then components... ;-) More work for the >>>> RM! >>>>> :-) >>>>> >>>>> Gary >>>>> >>>>> On Sun, Jan 20, 2019 at 5:06 AM Gilles Sadowski <gillese...@gmail.com> >>>>> wrote: >>>>> >>>>>> Le dim. 20 janv. 2019 à 04:56, Maxim Solodovnik <solomax...@gmail.com >>> >>>> a >>>>>> écrit : >>>>>>> >>>>>>> I can see there is activity with replacing clirr with japicmp, maybe >> it >>>>>>> worth to hold this release until commons-parent v48 will be released? >>>>>> >>>>>> You are the manager. :-) >>>>>> >>>>>> Gilles >>>>>> >>>>>>> >>>>>>> On Sun, 20 Jan 2019 at 05:52, Gilles Sadowski <gillese...@gmail.com> >>>>>> wrote: >>>>>>> >>>>>>>> Hi. >>>>>>>> >>>>>>>> Le sam. 19 janv. 2019 à 11:36, Maxim Solodovnik < >> solomax...@gmail.com >>>>> >>>>>> a >>>>>>>> écrit : >>>>>>>>> >>>>>>>>> I'm afraid I need help with this >>>>>>>>> since I don't understand why clirr reports these errors >>>>>>>> >>>>>>>> Nobody knows around here; but your test demonstrates that one of the >>>>>>>> errors is a false positive. >>>>>>>> So I suggest that, for good measure, you add calls to all the >> methods >>>>>>>> reported by Clirr; then the release notes can rightly mention >>>> something >>>>>>>> like: "An integration test (<short description of what you've done >>>>>> and/or >>>>>>>> a link to this discussion>) has shown that the errors mentioned in >> the >>>>>>>> Clirr report are false positives." >>>>>>>> >>>>>>>> Best regards, >>>>>>>> Gilles >>>>>>>> >>>>>>>> >>>>>>>>>> [...] >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> WBR >>>>>>> Maxim aka solomax >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>>>> >>>>>> >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> >>> >>> -- >>> WBR >>> Maxim aka solomax >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > > -- > WBR > Maxim aka solomax --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
