> On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik <solomax...@gmail.com> wrote:
>
> Hello All,
>
> It seems my previous post was missed somehow
> so will re-post here:
>
> I have added japicmp report here: [1] is has none issues
>
What do folks think about [1]? It looks much more promising than the clirr
report.
-Rob
> Additionally I have updated gist [2] it also show there are no issues
>
> In case this is not enough I propose to cancel RC2 and to release 5.0
>
> [1]
> https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html
> [2] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505
>
>> On Tue, 29 Jan 2019 at 20:35, Gary Gregory <garydgreg...@gmail.com> wrote:
>>
>> The bottom line is that new interface method in Collections 4.3 MUST be
>> default methods to avoid blowing up code. This is possible since Collection
>> now requires Java 8.
>>
>> Gary
>>
>>> On Mon, Jan 28, 2019 at 2:53 PM Rob Tompkins <chtom...@gmail.com> wrote:
>>>
>>>
>>>
>>>> On Jan 28, 2019, at 2:35 PM, sebb <seb...@gmail.com> wrote:
>>>>
>>>> On Mon, 28 Jan 2019 at 19:22, Marcelo Vanzin
>>>> <van...@cloudera.com.invalid> wrote:
>>>>>
>>>>> Haven't looked at the code, but if it's being compiled for java 8, and
>>>>> the new methods have a default implementation, then it's fine. clirr
>>>>> just complains because it's too old to know about default methods.
>>>>
>>>> I don't think so.
>>>>
>>>> I think Clirr is complaining because it affects source compatibility,
>>>> and the Maven report does not distinguish source/binary complaints.
>>>>
>>>
>>> By the way Japicmp says the same thing...that methods were added to
>>> interfaces.
>>>
>>>
>>>>>> On Mon, Jan 28, 2019 at 11:18 AM Rob Tompkins <chtom...@gmail.com>
>>> wrote:
>>>>>>
>>>>>> @Marcelo - Many thanks...Yes. That makes sense. Thanks. Seems like
>>> this release should be a -1 then because we’re breaking BC without a
>> major
>>> version change. Right??
>>>>>>
>>>>>> -Rob
>>>>>>
>>>>>>
>>>>>>> On Jan 28, 2019, at 2:07 PM, Marcelo Vanzin
>>> <van...@cloudera.com.INVALID> wrote:
>>>>>>>
>>>>>>> On Mon, Jan 28, 2019 at 11:01 AM Rob Tompkins <chtom...@gmail.com>
>>> wrote:
>>>>>>>> Before I vote on the the thread, does adding a method to an
>>> interface cause BC to break? I would think not. All of the clirr errors
>> are
>>> merely additions. Further the JAPICMP report confirms this.
>>>>>>>
>>>>>>> Existing classes that implement the interface won't have the newly
>>>>>>> added method. So if some other code calls that method in one of
>> these
>>>>>>> implementations, they'll get an "AbstractMethodError" (or something
>>>>>>> similar).
>>>>>>>
>>>>>>> --
>>>>>>> Marcelo
>>>>>>>
>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Marcelo
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>>> For additional commands, e-mail: dev-h...@commons.apache.org
>>>
>>>
>>
>
>
> --
> WBR
> Maxim aka solomax
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
