Le mer. 30 janv. 2019 à 14:56, Maxim Solodovnik <solomax...@gmail.com> a écrit : > > Latest version of test [2] shows all errors are false positive ....
Great; I missed that (sorry). Then, there is no reason to change the major version number. Is this still the [VOTE] thread? Regards, Gilles > > On Wed, 30 Jan 2019 at 20:23, Gilles Sadowski <gillese...@gmail.com> wrote: > > > Hi. > > > > Le mer. 30 janv. 2019 à 13:16, Rob Tompkins <chtom...@gmail.com> a écrit : > > > > > > > > > > > > > On Jan 30, 2019, at 1:12 AM, Maxim Solodovnik <solomax...@gmail.com> > > wrote: > > > > > > > > Hello All, > > > > > > > > It seems my previous post was missed somehow > > > > so will re-post here: > > > > > > > > I have added japicmp report here: [1] is has none issues > > > > > > > > > > What do folks think about [1]? It looks much more promising than the > > clirr report. > > > > I lost the thread... > > What (I think) we know: > > 1. A test showed that one of the errors reported by Clirr is a false > > positive. > > Extending the test could have settled the entire issue. > > 2. Japicmp was made to work and shows no BC breakage. > > > > This all goes towards concluding that the current RC is fine. > > So IIUC, mentioning the issue in the release notes is all that > > is necessary to perform the (minor) release. > > > > Regards, > > Gilles > > > > > > > > -Rob > > > > > > > Additionally I have updated gist [2] it also show there are no issues > > > > > > > > In case this is not enough I propose to cancel RC2 and to release 5.0 > > > > > > > > [1] > > > > > > https://dist.apache.org/repos/dist/dev/commons/collections/4.3-RC2/site/japicmp.html > > > > [2] https://gist.github.com/solomax/a6fbec6db71bb28dfe53afc566086505 > > > > > > > >> On Tue, 29 Jan 2019 at 20:35, Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > >> > > > >> The bottom line is that new interface method in Collections 4.3 MUST > > be > > > >> default methods to avoid blowing up code. This is possible since > > Collection > > > >> now requires Java 8. > > > >> > > > >> Gary > > > >> > > > >>> [...] > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > -- > WBR > Maxim aka solomax --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
