Hi Gilles,
I was just drafting an e-mail stating I had found my mistake.
> On 18 Feb 2019, at 22:18, Gilles Sadowski <gillese...@gmail.com> wrote:
>
> Hi.
>
> Le lun. 18 févr. 2019 à 16:22, Alex Herbert <alex.d.herb...@gmail.com> a
> écrit :
>>
>>>> [...]
>>>
>>> Command
>>> $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64/ mvn
>>> -Pcommons-rng-examples -Pjdk8-javadoc clean package site site:stage
>>> works on
>>> $ /usr/lib/jvm/java-9-openjdk-amd64/bin/java -version
>>> openjdk version "9-Debian"
>>> OpenJDK Runtime Environment (build 9-Debian+0-9b181-4bpo91)
>>> OpenJDK 64-Bit Server VM (build 9-Debian+0-9b181-4bpo91, mixed mode)
>>>
>>> I missed when the "jdk8-javadoc" profile became mandatory. Is there a
>>> way to have it activated automatically when necessary (e.g. when compiling
>>> with a JKD >= 8)?
>>>
>>> Gilles
>>
>> I’ve removed the linux distribution version of OpenJDK 9 and manually
>> installed OpenJDK 9, 10 and 11.
>>
>> I confirm these versions all require the --allow-script-in-comments option
>> for 'mvn javadoc:javadoc'. So I’ve reverted the pom.xml to put this back in
>> the profile for JDK 1.8+.
>>
>> I get a module error when building on OpenJDK 9:
>>
>> mvn -v
>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> 2018-06-17T19:33:14+01:00)
>> Maven home: /usr/local/apache-maven-3.5.4
>> Java version: 9, vendor: Oracle Corporation, runtime: /usr/lib/jvm/jdk-9
>> Default locale: en_GB, platform encoding: UTF-8
>> OS name: "linux", version: "4.4.0-142-generic", arch: "amd64", family: “unix"
>>
>> mvn clean site site:stage -Pcommons-rng-exampless
>>
>> [INFO] Reactor Summary:
>> [INFO]
>> [INFO] Apache Commons RNG 1.3-SNAPSHOT .................... SUCCESS [ 13.143
>> s]
>> [INFO] Apache Commons RNG Client API ...................... SUCCESS [ 8.144
>> s]
>> [INFO] Apache Commons RNG Core ............................ SUCCESS [ 19.623
>> s]
>> [INFO] Apache Commons RNG Simple .......................... SUCCESS [ 13.773
>> s]
>> [INFO] Apache Commons RNG Sampling ........................ SUCCESS [01:07
>> min]
>> [INFO] Apache Commons RNG Examples ........................ SUCCESS [ 3.871
>> s]
>> [INFO] Stress test example ................................ SUCCESS [ 6.715
>> s]
>> [INFO] Sampling example ................................... SUCCESS [ 6.155
>> s]
>> [INFO] Quadrature example ................................. SUCCESS [ 5.808
>> s]
>> [INFO] JMH Benchmark ...................................... SUCCESS [ 22.310
>> s]
>> [INFO] JPMS Integration test .............................. SUCCESS [ 1.895
>> s]
>> [INFO] JPMS module example (library) ...................... FAILURE [ 0.559
>> s]
>> [INFO] JPMS module example (application) 1.3-SNAPSHOT ..... SKIPPED
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] BUILD FAILURE
>> [INFO]
>> ------------------------------------------------------------------------
>> [INFO] Total time: 02:49 min
>> [INFO] Finished at: 2019-02-18T13:54:01Z
>> [INFO]
>> ------------------------------------------------------------------------
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on
>> project commons-rng-examples-jpms-lib: failed to get report for
>> org.apache.maven.plugins:maven-surefire-report-plugin: Failed to execute
>> goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
>> (default-compile) on project commons-rng-examples-jpms-lib: Compilation
>> failure: Compilation failure:
>> [ERROR]
>> /home/ah403/git/commons-rng/commons-rng-examples/examples-jpms/jpms-lib/src/main/java/module-info.java:[18,36]
>> module not found: org.apache.commons.rng.api
>> [ERROR]
>> /home/ah403/git/commons-rng/commons-rng-examples/examples-jpms/jpms-lib/src/main/java/module-info.java:[19,36]
>> module not found: org.apache.commons.rng.sampling
>>
>>
>> I tried mvn 3.5.4 and 3.6.0.
>>
>> This can be reduced to just running:
>>
>> mvn compile in commons-rng-examples/examples-jpms
>
> Works here (maven downloads the "1.3-SNAPSHOT" artefacts from the
> Apache repository).
>
>>
>> Something about this machine setup does not like the modules setup. I had a
>> dig around and thought updating this module definition would work:
>>
>> module org.apache.commons.rng.examples.jpms.lib {
>> requires org.apache.commons.rng;
>> requires org.apache.commons.rng.sampling.distribution;
>> exports org.apache.commons.rng.examples.jpms.lib;
>> }
>>
>> The module currently requires ‘o.a.c.rng.api’ which doesn’t exist and
>> ‘o.a.c.rng.sampling’ which needs .distribution added to the end. But that
>> made no difference.
>>
>> I am going to try on another machine to get the modules built.
>
> Try building from the top-level and adding the "package" goal:
>
> $ mvn -Pcommons-rng examples clean package
Correct.
Somehow in repeat attempts at doing this I dropped the packaging of the code,
so obviously it cannot find the module-info when building the JPMS sub-modules
since there are no jars in the other sub-module dependencies. At various
testing points I had ‘install’ in my mvn command so that worked but I kept
going back to the wrong command to build from clean. However I learnt a lot
today about Java 9 modules when trying to understand what was wrong so it was
useful for me.
So the current master branch does build and does create the java docs with the
MathJax script. My previous jdk9 version was too old. Recent versions work.
Case closed.
Alex
>
> Gilles
>
>>>> [...]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
