On Sat, Sep 28, 2019 at 12:04 PM Gary Gregory <garydgreg...@gmail.com> wrote:
> I can confirm that if I delete all of: > > src\native\windows\apps\prunmgr\WINXP_X86_GUI_RELEASE > src\native\windows\apps\prunsrv\WINXP_X86_EXE_RELEASE > src\native\windows\apps\prunsrv\WINXP_X64_EXE_RELEASE > > I can build without errors but with warnings: > > .\..\..\apps\prunsrv\prunsrv.c(323): warning C4996: '_wfopen': This > function or variable may be unsafe. Consider using _wfopen_s instead. To > disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for > details. > C:\Program Files (x86)\Windows > Kits\10\include\10.0.17763.0\ucrt\corecrt_wstdio.h(130): note: see > declaration of '_wfopen' > .\..\..\apps\prunsrv\prunsrv.c(347): warning C4996: '_wfopen': This > function or variable may be unsafe. Consider using _wfopen_s instead. To > disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for > details. > C:\Program Files (x86)\Windows > Kits\10\include\10.0.17763.0\ucrt\corecrt_wstdio.h(130): note: see > declaration of '_wfopen' > .\..\..\apps\prunsrv\prunsrv.c(1339): warning C4996: '_snprintf': This > function or variable may be unsafe. Consider using _snprintf_s instead. To > disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for > details. > C:\Program Files (x86)\Windows > Kits\10\include\10.0.17763.0\ucrt\stdio.h(1961): note: see declaration of > '_snprintf' > .\..\..\apps\prunsrv\prunsrv.c(1341): warning C4996: '_snprintf': This > function or variable may be unsafe. Consider using _snprintf_s instead. To > disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for > details. > C:\Program Files (x86)\Windows > Kits\10\include\10.0.17763.0\ucrt\stdio.h(1961): note: see declaration of > '_snprintf' > rc /l 0x409 /d "NDEBUG" /i ".\..\..\include" /fo > WINXP_X86_EXE_RELEASE\prunsrv.res .\..\../apps/prunsrv/prunsrv.rc > FWIW, using: Microsoft (R) C/C++ Optimizing Compiler Version 19.21.27702.2 for x86 Copyright (C) Microsoft Corporation. All rights reserved. Gary > > Gary > > > > On Sat, Sep 28, 2019 at 11:53 AM Gary Gregory <garydgreg...@gmail.com> > wrote: > >> On Sat, Sep 28, 2019 at 10:03 AM sebb <seb...@gmail.com> wrote: >> >>> On Sat, 28 Sep 2019 at 13:39, Gary Gregory <garydgreg...@gmail.com> >>> wrote: >>> > >>> > It seems we provide too much in the src zip file like exe and obj >>> files. >>> > Also old pdb files because I get: >>> > >>> > .\..\..\src\cmdline.c: fatal error C1051: program database file, >>> > >>> 'C:\temp\rc\commons-daemon-1.2.2-src\src\native\windows\apps\prunsrv\WINXP_X86_EXE_RELEASE\prunsrv-src.pdb', >>> > has an obsolete format, delete it and recompile >>> > NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual >>> > >>> Studio\2019\Community\VC\Tools\MSVC\14.21.27702\bin\HostX86\x86\cl.EXE"' : >>> > return code '0x2' >>> > >>> > Since we do not provide class files and jars in the src zip, why >>> should we >>> > provide pdb, objs and exes in these all caps folders? >>> > >>> > It seems we should NOT deliver the following folders in the src zip >>> which >>> > now contain objs and exes: >>> > >>> > src\native\windows\apps\prunmgr\WINXP_X86_GUI_RELEASE >>> > src\native\windows\apps\prunsrv\WINXP_X86_EXE_RELEASE >>> > src\native\windows\apps\prunsrv\WINXP_X64_EXE_RELEASE >>> > >>> > WDYT? >>> >>> Looks like the build created the files in the wrong directories? >>> >>> The src zip also contains: >>> src/native/unix/configure >>> AIUI this is a generated file; I would expect it to be in the binary >>> artifact, if anywhere >>> >>> Also there are some Git files missing from the src zip. >>> Not sure if that is intentional? >>> >>> CONTRIBUTING.md >>> HOWTO-RELEASE.txt >>> README.md >>> >> >> I certainly would expect CONTRIBUTING.md and README.md to be in the src >> zip, not quite a blocker for me. I am more concerned that we are including >> all of these OBJ and EXE files. >> >> Gary >> >>> >>> >>> > Gary >>> > >>> > >>> > On Wed, Sep 25, 2019 at 10:57 AM Mark Thomas <ma...@apache.org> wrote: >>> > >>> > > A further regression has been identified in the 1.2.0/1.2.1 releases >>> so >>> > > I'd like to get 1.2.2 released to address it. So, time for another >>> > > release vote. >>> > > >>> > > Notable changes since 1.2.1 include: >>> > > - Correct a regression (DAEMON-408) that caused Windows services to >>> > > crash on start-up when the universal C runtime was not available >>> > > >>> > > The full set of changes is in the changelog >>> > > >>> > > 1.2.2 RC1 can be obtained from (r36024) >>> > > https://dist.apache.org/repos/dist/dev/commons/daemon/ >>> > > >>> > > The git tag is: >>> > > Tag: COMMONS_DAEMON_1_2_2_RC1 >>> > > URL: >>> > > >>> > > >>> https://gitbox.apache.org/repos/asf?p=commons-daemon.git;a=commit;h=cb6754d51a008418ed93e29cde141f046766fee3 >>> > > Hash: cb6754d51a008418ed93e29cde141f046766fee3 >>> > > >>> > > The Maven Staging repo is: >>> > > >>> https://repository.apache.org/content/repositories/orgapachecommons-1471/ >>> > > >>> > > The Windows binaries have been signed by the DigiCert (formerly >>> > > Symantec) code signing service. >>> > > >>> > > Files signed with my preferred key: >>> > > http://people.apache.org/~markt/ >>> > > KEYS file is standard Apache Commons keys file: >>> > > http://www.apache.org/dist/commons/KEYS >>> > > >>> > > >>> > > [ ] Approved - go ahead and release Commons Daemon 1.2.2 RC1 as 1.2.2 >>> > > [ ] Broken - do not release because... >>> > > >>> > > --------------------------------------------------------------------- >>> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> > > For additional commands, e-mail: dev-h...@commons.apache.org >>> > > >>> > > >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>>
