On 04/11/2019 12:43, Gilles Sadowski wrote:
Hello.
Le lun. 4 nov. 2019 à 13:05, Alex Herbert <alex.d.herb...@gmail.com> a écrit :
On 04/11/2019 00:42, Gilles Sadowski wrote:
Hi.
[...]
So there are at least two options:
1. Release using JDK 9
+1
OK. I'll run through the release with JDK 9. I do not think we have any
NIO classes so the issue raised by Gary should not be present.
Here
$ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn
-Pcommons-rng-examples clean package install site site:stage
built fine (but I did not check the reports).
Good to know.
I've been through a dry run and the outputs look as expected.
This command does not work with Java 9:
mvn -N -Pcommons-rng-examples commons-build:download-page
You have to build the download page using Java 8. Then switch to Java 9
again.
I am looking at the clirr report to check and add @since tags.
Q. How to annotate implementation of a new interface on an existing class?
Should all the new interface methods have @since tags?
Isn't it good enough to have the tag in the class Javadoc?
For new classes. This is new methods added to existing classes due to
implementation of a new interface.
I've taken the safe option to put @since on all the new methods.
I also added @since to all the new enum values in RandomSource.
Alex
Gilles
[...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
