Pardon vague.. My vote: +1 (binding)
> On Jan 2, 2020, at 12:16 PM, Rob Tompkins <chtom...@gmail.com> wrote: > > +1 > >> On Jan 2, 2020, at 12:15 PM, Gary Gregory <garydgreg...@gmail.com> wrote: >> >> The fix would be to exclude this _test_ fixture file from the RAT check in >> the POM. >> >> Not a blocker IMO. >> >> Gary >> >> On Thu, Jan 2, 2020, 11:53 Rob Tompkins <chtom...@gmail.com> wrote: >> >>> +0 (could be convinced of +1) >>> >>> RAT: >>> >>> ***************************************************** >>> Summary >>> ------- >>> Generated at: 2020-01-02T10:45:36-05:00 >>> >>> Notes: 3 >>> Binaries: 4 >>> Archives: 1 >>> Standards: 287 >>> >>> Apache Licensed: 286 >>> Generated Documents: 0 >>> >>> JavaDocs are generated, thus a license header is optional. >>> Generated files do not require license headers. >>> >>> 1 Unknown Licenses >>> >>> ***************************************************** >>> >>> Files with unapproved licenses: >>> >>> src/test/resources/empty.bin >>> >>> ***************************************************** >>> >>> -Rob >>> >>>> On Jan 2, 2020, at 9:38 AM, Gary Gregory <garydgreg...@gmail.com> wrote: >>>> >>>> My +1 >>>> >>>> Gary >>>> >>>> >>>> On Mon, Dec 30, 2019 at 7:59 PM Gary Gregory <ggreg...@apache.org> >>> wrote: >>>> >>>>> We have fixed quite a few bugs and added some significant enhancements >>>>> since Apache Commons Codec 1.13 was released, so I would like to release >>>>> Apache Commons Codec 1.14. >>>>> >>>>> Apache Commons Codec 1.14 RC1 is available for review here: >>>>> https://dist.apache.org/repos/dist/dev/commons/codec/1.14-RC1 (svn >>>>> revision 37409) >>>>> >>>>> The Git tag commons-codec-1.14-RC1 commit for this RC is >>>>> af7b94750e2178b8437d9812b28e36ac87a455f2 which you can browse here: >>>>> >>>>> >>> https://gitbox.apache.org/repos/asf?p=commons-codec.git;a=commit;h=af7b94750e2178b8437d9812b28e36ac87a455f2 >>>>> You may checkout this tag using: >>>>> git clone https://gitbox.apache.org/repos/asf/commons-codec.git >>>>> --branch commons-codec-1.14-RC1 commons-codec-1.14-RC1 >>>>> >>>>> Maven artifacts are here: >>>>> >>>>> >>> https://repository.apache.org/content/repositories/orgapachecommons-1483/commons-codec/commons-codec/1.14/ >>>>> >>>>> These are the artifacts and their hashes: >>>>> >>>>> #Release SHA-512s >>>>> #Mon Dec 30 19:44:19 EST 2019 >>>>> >>>>> >>> commons-codec-1.14-bin.tar.gz=bb21a15d0415513050d7738914b66bfe1f4612d7b44805ba208ec6d4fd923af244c98e828986cd4aa6cdcf9c78e23de981b5a34ac1abf805691a55f5be8cc0cf >>>>> >>>>> >>> commons-codec-1.14-bin.zip=1119a418683ee9b599148b90056055fa93062e839ef426004c756c8054548cc1a80479f3b77a5a60c292e05ae67ae8699d46ae4ec25bad0070e17eb0e9e69756 >>>>> >>>>> >>> commons-codec-1.14-javadoc.jar=53dda4afcd159debd68aa8b3fdb22c6de02903e725d82203db2c8692da86091a4435664eb72df12a69e65f461712435ece81da9f0658587b2f6df3991d5a048a >>>>> >>>>> >>> commons-codec-1.14-sources.jar=a0791dacf27154fa9453e16856d5b911b568eaada52a02535bb6170bdd13e97da32051d5359aa92ad0e69948450ff6f463aedc9a04f5f9ff4d5704e31e51a6b9 >>>>> >>>>> >>> commons-codec-1.14-src.tar.gz=1a98dc017d3213d8a89d11524683d45e9616fc6da8b4723cd1cfae23d73fefafeccc1c0f2994d1c4c52d79e1b825e4e09e601071572e2eb229105b3b4fd4a49b >>>>> >>>>> >>> commons-codec-1.14-src.zip=0a7ebe348c9b12ee360e137c5bee833df4f7cfb259435ce6bda24073e8e1d3b76a202d4fd451efe29ddebcbcc31b3f7a287c7530d23bdc672129280d5c12d90e >>>>> >>>>> >>> commons-codec-1.14-test-sources.jar=02c4fba74f028749abbf4bc44b328ed40fae3f60f53998dcaa2699284d337180b934ca93344271739f4e4df44643e87f7ce12dee35b252fa60f8f32ae60df460 >>>>> >>>>> >>> commons-codec-1.14-tests.jar=18dd09a0bd91040d857d84b0be39a482e884c701bcbbb5bbba990c80cf02d0270158bdbce8fa1b4473eeeb86d03ce1c4a3232d280f8b1356ee5c9f64d8a685a8 >>>>> >>>>> I have tested this with: >>>>> >>>>> mvn -V -Duser.name=%my_apache_id% >>>>> -Dcommons.release-plugin.version=%commons.release-plugin.version% >>> -Prelease >>>>> -Pjacoco -Pjapicmp -Ptest-deploy clean package site deploy >>>>> >>>>> using: >>>>> >>>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >>>>> Maven home: C:\Java\apache-maven-3.6.3\bin\.. >>>>> Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: C:\Program >>>>> Files\Java\jdk1.8.0_231\jre >>>>> Default locale: en_US, platform encoding: Cp1252 >>>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" >>>>> >>>>> Details of changes since 1.13 are in the release notes: >>>>> >>>>> >>> https://dist.apache.org/repos/dist/dev/commons/codec/1.14-RC1/RELEASE-NOTES.txt >>>>> >>>>> >>> https://dist.apache.org/repos/dist/dev/commons/codec/1.14-RC1/site/changes-report.html >>>>> >>>>> Site: >>>>> >>>>> >>> https://dist.apache.org/repos/dist/dev/commons/codec/1.14-RC1/site/index.html >>>>> (note some *relative* links are broken and the 1.14 directories are >>>>> not yet created - these will be OK once the site is deployed.) >>>>> >>>>> JApiCmp Report (compared to 1.13): >>>>> >>>>> >>> https://dist.apache.org/repos/dist/dev/commons/codec/1.14-RC1/site/japicmp.html >>>>> >>>>> RAT Report: >>>>> >>>>> >>> https://dist.apache.org/repos/dist/dev/commons/codec/1.14-RC1/site/rat-report.html >>>>> >>>>> KEYS: >>>>> https://www.apache.org/dist/commons/KEYS >>>>> >>>>> Please review the release candidate and vote. >>>>> This vote will close no sooner that 72 hours from now. >>>>> >>>>> [ ] +1 Release these artifacts >>>>> [ ] +0 OK, but... >>>>> [ ] -0 OK, but really should fix... >>>>> [ ] -1 I oppose this release because... >>>>> >>>>> Thank you, >>>>> >>>>> Gary Gregory, >>>>> Release Manager (using key 86fdc7e2a11262cb) >>>>> >>>>> For following is intended as a helper and refresher for reviewers. >>>>> >>>>> Validating a release candidate >>>>> ============================== >>>>> >>>>> These guidelines are NOT complete. >>>>> >>>>> Requirements: Git, Java, Maven. >>>>> >>>>> You can validate a release from a release candidate (RC) tag as follows. >>>>> >>>>> 1) Clone and checkout the RC tag >>>>> >>>>> git clone https://gitbox.apache.org/repos/asf/commons-codec.git >>> --branch >>>>> commons-codec-1.14-RC1 commons-codec-1.14-RC1 >>>>> cd commons-codec-1.14-RC1 >>>>> >>>>> 2) Check Apache licenses >>>>> >>>>> This step is not required if the site includes a RAT report page which >>> you >>>>> then must check. >>>>> >>>>> mvn apache-rat:check >>>>> >>>>> 3) Check binary compatibility >>>>> >>>>> Older components still use Apache Clirr: >>>>> >>>>> This step is not required if the site includes a Clirr report page which >>>>> you then must check. >>>>> >>>>> mvn clirr:check >>>>> >>>>> Newer components use JApiCmp with the japicmp Maven Profile: >>>>> >>>>> This step is not required if the site includes a JApiCmp report page >>> which >>>>> you then must check. >>>>> >>>>> mvn install -DskipTests -P japicmp japicmp:cmp >>>>> >>>>> 4) Build the package >>>>> >>>>> mvn -V clean package >>>>> >>>>> You can record the Maven and Java version produced by -V in your VOTE >>>>> reply. >>>>> To gather OS information from a command line: >>>>> Windows: ver >>>>> Linux: uname -a >>>>> >>>>> 5) Build the site for a single module project >>>>> >>>>> Note: Some plugins require the components to be installed instead of >>>>> packaged. >>>>> >>>>> mvn site >>>>> Check the site reports in: >>>>> - Windows: target\site\index.html >>>>> - Linux: target/site/index.html >>>>> >>>>> 6) Build the site for a multi-module project >>>>> >>>>> mvn site >>>>> mvn site:stage >>>>> Check the site reports in: >>>>> - Windows: target\site\index.html >>>>> - Linux: target/site/index.html >>>>> >>>>> -the end- >>>>> >>>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >>> >>> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
