> On 3 Jan 2020, at 14:07, Rob Tompkins <chtom...@gmail.com> wrote: > > > >> On Jan 3, 2020, at 9:02 AM, Rob Tompkins <chtom...@gmail.com> wrote: >> >> >> >>> On Jan 2, 2020, at 9:27 PM, Rob Tompkins <chtom...@gmail.com> wrote: >>> >>> >>> >>>> On Jan 2, 2020, at 6:55 PM, Alex Herbert <alex.d.herb...@gmail.com> wrote: >>>> >>>> >>>> >>>>> On 2 Jan 2020, at 16:53, Rob Tompkins <chtom...@gmail.com> wrote: >>>>> >>>>> +0 (could be convinced of +1) >>>>> >>>>> RAT: >>>>> >>>>> ***************************************************** >>>>> Summary >>>>> ------- >>>>> Generated at: 2020-01-02T10:45:36-05:00 >>>>> >>>>> Notes: 3 >>>>> Binaries: 4 >>>>> Archives: 1 >>>>> Standards: 287 >>>>> >>>>> Apache Licensed: 286 >>>>> Generated Documents: 0 >>>>> >>>>> JavaDocs are generated, thus a license header is optional. >>>>> Generated files do not require license headers. >>>>> >>>>> 1 Unknown Licenses >>>>> >>>>> ***************************************************** >>>>> >>>>> Files with unapproved licenses: >>>>> >>>>> src/test/resources/empty.bin >>>>> >>>>> ***************************************************** >>>> >>>> Q. How did you manage to get this error? >>>> >>>> apache-rat:check is in the default goal run by travis and >>>> 'src/test/resources/empty.bin’ has been in the pom.xml exclusions for a >>>> while. >>>> >>>> I cannot reproduce this. >>>> >>> >>> Curious. Not certain, but the build was with java 11. Let me start from >>> scratch in the morning and see if I can reproduce it. If I can indeed, then >>> I’ll send over my full mvn -version >> >> I got this error when building from the unzipped -src.zip artifact. I’m also >> getting it when I run with the environment: > > Only in the site’s report that gets generated. It’s not in the man > apache-rat:check.
OK. So the <reporting> tag should have the same config as the <build> tag for the rat check. Strange that the other files do not get flagged that have to be excluded in the <build> section: <exclude>src/test/resources/bla.tar.xz</exclude> <exclude>src/test/resources/empty.bin</exclude> <exclude>src/test/resources/small.bin</exclude> I’ve just run the site build myself. I guess that the empty.bin is a problem as the file is empty. Rat must skip checking the file extension .bin that allows it to decide that small.bin and bla.tar.xz are binary files. bla.tar is detected as an archive and also ignored: !????? src/test/resources/empty.bin A src/test/resources/bla.tar B src/test/resources/small.bin B src/test/resources/bla.tar.xz If I duplicate the rat configuration to the <reporting> tag then this error does not occur. Alex > > -Rob > >> >> mvn -version >> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >> Maven home: /usr/local/Cellar/maven/3.6.3/libexec >> Java version: 11.0.5, vendor: Amazon.com <http://amazon.com/> >> <http://amazon.com/ <http://amazon.com/>> Inc., runtime: >> /Library/Java/JavaVirtualMachines/amazon-corretto-11.jdk/Contents/Home >> Default locale: en_US, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.15.2", arch: "x86_64", family: “mac" >> >> Not sure if that helps. >> >> -Rob >> >>> >>> -Rob >>> >>>> Gary, >>>> >>>> I have been on holiday so have not had time to do a full RC review. I may >>>> be able to do so in the next few days unless someone gets there first. >>>> >>>> Alex >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>>> <mailto:dev-unsubscr...@commons.apache.org> >>>> <mailto:dev-unsubscr...@commons.apache.org >>>> <mailto:dev-unsubscr...@commons.apache.org>> >>>> For additional commands, e-mail: dev-h...@commons.apache.org >>>> <mailto:dev-h...@commons.apache.org> <mailto:dev-h...@commons.apache.org >>>> <mailto:dev-h...@commons.apache.org>>
