On Sat, Apr 11, 2020 at 1:55 PM Alex Remily <alex.rem...@gmail.com> wrote:
> This looks to be done. I added a comment to the ticket with a link to the > commit. > > > https://github.com/apache/commons-crypto/commit/3466943e4552474ab681d7852dbfa62c74d8e1ce Thanks Alex, I resolved the parent ticket and added it to changes.xml. When I run tests and look at code coverage JaCoCo report, it does not look great IMO: mvn -V clean install site -P jacoco -P japicmp Then open the site in target/site Is there any chance you can improve on this? Thank you, Gary > > Alex > > On Sat, Apr 11, 2020 at 11:54 AM Gary Gregory <garydgreg...@gmail.com> > wrote: > > > On Sat, Apr 11, 2020 at 8:43 AM Gary Gregory <garydgreg...@gmail.com> > > wrote: > > > > > On Fri, Apr 10, 2020 at 8:38 PM Marcelo Vanzin <van...@apache.org> > > wrote: > > > > > >> (-CCs) > > >> > > >> Hi Gary, thanks for volunteering to help. If needed I can try helping > > with > > >> the release process (e.g. uploading artifacts), but I don't really > have > > >> the > > >> ability to build anything but the linux64 native lib (maybe the > linux32 > > >> one > > >> if I can find the right packages or docker image). > > >> > > > > > The ticket: > > > > https://issues.apache.org/jira/browse/CRYPTO-59 > > > > refers to the incomplete subtask: > > > > https://issues.apache.org/jira/browse/CRYPTO-126 > > > > May you complete this task with a PR on GitHub? If it is already done, > then > > please update the ticket with what classes and methods perform the tests. > > > > Thank you, > > Gary > > > > > > > > > > > >> I looked at the 1.0 release and it seems to include linux32/64, > win32/64 > > >> and macos64. > > > > > > > > > You can review what is in git master or what I also pushed as a > snapshot > > > build to > > > > > > https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-crypto/1.1.0-SNAPSHOT > > > > > > > > >> > > >> src/changes/changes.xml probably needs some love too. > > >> > > > > > > Indeed, this file was not updated with each change. It needs updates. A > > PR > > > is welcome or a message here confirming that all JIRAs listed on > > > https://issues.apache.org/jira/projects/CRYPTO/versions/12335578 are > > > indeed in git master. Then I can update the changes.xml if no one > > submits a > > > PR. > > > > > > Gary > > > > > > > > >> > > >> > > >> On Fri, Apr 10, 2020 at 5:02 PM Gary Gregory <garydgreg...@gmail.com> > > >> wrote: > > >> > > >> > I'll see what I can do over the weekend. > > >> > > > >> > Gary > > >> > > > >> > > > >> > On Thu, Apr 9, 2020 at 8:45 PM Alex Remily <alex.rem...@gmail.com> > > >> wrote: > > >> > > > >> >> Commons Crypto Team, > > >> >> > > >> >> It's been four years since the last release of commons crypto. > There > > >> have > > >> >> been many updates to the repository since then, notably the > > >> integration of > > >> >> OpenSSL 1.1.1, and native arm64 support. Geoff Blake (copied) and > I > > >> have > > >> >> been advocating for a new release, and we need assistance from > > someone > > >> who > > >> >> knows the release process and has the necessary accesses. If any > of > > >> you > > >> >> are willing to assist with this effort, please come up on the > apache > > >> >> commons dev list (also copied) and announce yourself. > > >> >> > > >> >> Looking forward to hearing from you. > > >> >> > > >> >> Alex > > >> >> > > >> > > > >> > > > > > >
