On Wed, Apr 15, 2020 at 7:01 PM Alex Remily <alex.rem...@gmail.com> wrote:
> I've seen the expected exception error, but rarely and I've never been able > to reproduce it. I'm surprised it's come up on Travis because it's only > come up a few times for me in the hundreds of builds I've done. Maybe we > log it as a bug just to document it, but like I said, I don't know how to > reproduce it for a fix. I know I've seen it on a Mac, so it's not just an > Ubuntu issue. > > Regarding the code coverage, Just a heads up that I've started working > through the org.apache.commons.crypto.stream package to hook in some tests > where I can. Please consider providing PRs for small change sets instead of a single 'big bang' PR will be much harder to digest and might conflict with other PRs. Gary > Slow going, but I'm planning on just plugging away at it > until I've gone through all the packages and either added tests or decided > I won't or can't. Let me know if you want to split the packages between > the two of us. > > Alex > > On Wed, Apr 15, 2020 at 5:46 PM Geoffrey Blake <geoffrey.w.bl...@gmail.com > > > wrote: > > > So, I built commons-crypto against SSL 1.0.2n on Ubuntu 18.04LTS and > > all the tests pass. The code coverage bumps to 72%, I'm guessing if I > > did Mac we'd see the 73% coverage seen from Travis CI. > > > > @Gary, what should a reasonable coverage target be? 73% is not great, > > but not sure how much higher this can get with many code paths that > > may be unreachable from unit-testing from what I'm seeing (private > > constructors, private overridden methods that are not used, static > > classes etc). There are some functions that can be added, but is it > > worth it right now for getting a new release? > > > > Still, I've seen this error pop up in Travis multiple times now for the > > repo: > > > > 3040[ERROR] > > testGcmTamperedData(org.apache.commons.crypto.cipher.GcmCipherTest) > > Time elapsed: 0.019 s <<< ERROR! > > 3041java.lang.Exception: Unexpected exception, > > expected<javax.crypto.AEADBadTagException> but > > was<java.lang.InternalError> > > 3042 at > > > org.apache.commons.crypto.cipher.GcmCipherTest.testGcmTamperedData(GcmCipherTest.java:224) > > > > Is that an error in commons-crypto, or something up with the Travis CI > > env? I haven't seen it on my dev environments. > > > > -Geoff > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > >
